🌱 Enable using errors.Is with ErrResourceDiscoveryFailed error

[tamalsaha]

No description provided.

[k8s-ci-robot]

Hi @tamalsaha. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: tamalsaha
Once this PR has been reviewed and has the lgtm label, please assign fillzpp for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

• OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[troy0820]

Suggested change

	_, ok := target.(*ErrResourceDiscoveryFailed)
	return ok
	ep := &ErrResourceDiscoveryFailed{}
	return errors.As(target,ep)

We have done this for Terminal error in pkg/reconcile/reconcile.go:179

controller-runtime/pkg/reconcile/reconcile.go

Lines 179 to 182 in e6c3d13

	func (te *terminalError) Is(target error) bool {
	tp := &terminalError{}
	return errors.As(target, &tp)
	}

I am not sure if this is needed but I would add a test if you are adding this change.

[tamalsaha]

---

I don't think Is should be implemented using As, since As calls unwrap.

[alvaroaleman]

It doesn't matter, if the Is implementation doesn't call unwrap, errors.Is does, so the result is the same. Please add a test though.

[alculquicondor]

/ok-to-test

[sbueringer]

@tamalsaha Do you have time to address the finding above?

[tamalsaha]

Sorry, I don't have time and don't hold this up incase anyone else is interested in doing something similar.