Empty validation field when generating CRDs with multiple versions

[sebgl]

I think there's a bug which prevents the trivial versions option to work as expected.

How to reproduce:

• setup an apis/ pkg using a kubebuilder directory structure, containing multiple versions of the same CRD, with a different spec:

* apis/mycrd/v1alpha1
* apis/mycrd/v1beta1

• generate the CRD manifests using crd:trivialVersions=true
• according to the code, the CRD top-level validation field should be filled with the schema of the version which has storage: true:

https://github.com/kubernetes-sigs/controller-tools/blob/master/pkg/crd/gen.go#L98-L116

• the resulting CRD has an empty validation field, which should not happen, I think?

Unless we explicitly want to have no validation set when multiple versions are specified? (Which currently happens, I think, as an undesired side-effect in the code).

[sebgl]

Looking at the code, the validation and schema fields are mutated in toTrivialVersions():
https://github.com/kubernetes-sigs/controller-tools/blob/master/pkg/crd/gen.go#L98-L116

I think we process each individual groupKind as many times as there are corresponding versions, but since we then end up mutating the same CRD multiple times, its validation field becomes nil starting the second iteration. I don't think that's intended?

I tested with having 2 versions of the same resource: FindKubeKinds() returns 2 items (the exact same one for each version), and processes them both.
The second call to toTrivialVersions() processes a structure which already has its validation and schema fields modified.

I have a PR with a fix almost ready.

[fejta-bot]

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle stale

[sebgl]

/remove-lifecycle stale

I think this is still an issue. #350 is pending review. #365 (comment) adds integration tests to catch this bug.

[fejta-bot]

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle stale

[fejta-bot]

Stale issues rot after 30d of inactivity.
Mark the issue as fresh with /remove-lifecycle rotten.
Rotten issues close after an additional 30d of inactivity.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle rotten

[fejta-bot]

Rotten issues close after 30d of inactivity.
Reopen the issue with /reopen.
Mark the issue as fresh with /remove-lifecycle rotten.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/close

[k8s-ci-robot]

@fejta-bot: Closing this issue.

In response to this:

Rotten issues close after 30d of inactivity.
Reopen the issue with /reopen.
Mark the issue as fresh with /remove-lifecycle rotten.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.