Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🐛 Fix description generation to work for all types of fields #118

Merged
merged 1 commit into from
Dec 17, 2018
Merged

🐛 Fix description generation to work for all types of fields #118

merged 1 commit into from
Dec 17, 2018

Conversation

sohankunkerkar
Copy link
Member

@k8s-ci-robot k8s-ci-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Dec 15, 2018
@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Dec 15, 2018
@sohankunkerkar
Copy link
Member Author

/assign @droot

@sohankunkerkar sohankunkerkar changed the title 🐛 Fix description generation to work for all types of fields :bug: Fix description generation to work for all types of fields Dec 15, 2018
@sohankunkerkar sohankunkerkar changed the title :bug: Fix description generation to work for all types of fields (:bug:) Fix description generation to work for all types of fields Dec 15, 2018
@sohankunkerkar sohankunkerkar changed the title (:bug:) Fix description generation to work for all types of fields 🐛 Fix description generation to work for all types of fields Dec 15, 2018
droot
droot reviewed Dec 17, 2018
View reviewed changes
Copy link
Contributor

@droot droot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look good to me. I have a minor comment about renaming a variable name.

pkg/internal/codegen/parse/util.go Outdated Show resolved Hide resolved
@droot droot added lgtm "Looks good to me", indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Dec 17, 2018
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

Approval requirements bypassed by manually added approval.

This pull-request has been approved by: sohankunkerkar

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit 950a0e8 into kubernetes-sigs:master Dec 17, 2018
@grantr grantr mentioned this pull request Jan 16, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@droot droot droot left review comments

@DirectXMan12 DirectXMan12 Awaiting requested review from DirectXMan12

@pwittrock pwittrock Awaiting requested review from pwittrock

Assignees

@droot droot

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sohankunkerkar @k8s-ci-robot @droot