🐛 CRD generation: remove status before writing #630
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
the
cncf-cla: yes
k8s-ci-robot
added
the
size/M
justinsb
force-pushed
the
strip_crd_status
branch
2 times, most recently
from
485e19d to
82dce5f
Compare
k8s-ci-robot
added
the
needs-rebase
justinsb
force-pushed
the
strip_crd_status
branch
from
82dce5f to
7cf088b
Compare
k8s-ci-robot
removed
the
needs-rebase
|
It's odd to include status for two reasons:
|
|
The Kubernetes project currently lacks enough contributors to adequately respond to all issues and PRs. This bot triages issues and PRs according to the following rules:
You can:
Please send feedback to sig-contributor-experience at kubernetes/community. /lifecycle stale |
k8s-ci-robot
added
the
lifecycle/stale
yuwenma
reviewed
Feb 25, 2022
pkg/genall/genall.go
Outdated
| @@ -147,6 +160,41 @@ func (g GenerationContext) WriteYAML(itemPath string, objs ...interface{}) error | |||
| return nil | |||
| } | |||
|
|
|||
| // MarshalToYAML is based on sigs.k8s.io/yaml.Marshal, but allows for transforming the final data before writing. | |||
There was a problem hiding this comment.
Well spotted - thanks!
|
This PR can greatly highlight and reemphasize the definition of object spec and status |
|
/lgtm |
k8s-ci-robot
added
the
lgtm
|
/assign @mengqiy |
|
/hold |
k8s-ci-robot
added
the
do-not-merge/hold
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: justinsb, mengqiy The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
|
/retest |
It's tricky to get the existing CRD types to not include the status, so we instead allow for filtering of the map just before writing. Issue kubernetes-sigs#456
justinsb
force-pushed
the
strip_crd_status
branch
from
7cf088b to
4e829c2
Compare
k8s-ci-robot
removed
the
lgtm
k8s-ci-robot
removed
the
do-not-merge/hold
|
/lgtm |
k8s-ci-robot
added
the
lgtm
4 tasks
akutz
added a commit
to vmware-tanzu/vm-operator
that referenced
this pull request
Nov 19, 2022
This patch updates hack/tools to use controller-tools 0.10.0. In version 0.9+ of controller-tools, an upstream patch removed the status sub-resource from the CustomResourceDefinition (CRD) for a...CRD. That's right, the "kind: CustomResourceDefinition" no longer has a status sub-resource, and that's why all of the manifests have been touched during this patch. For more info, please see kubernetes-sigs/controller-tools#630.
akutz
added a commit
to vmware-tanzu/vm-operator
that referenced
this pull request
Dec 1, 2022
This patch updates hack/tools to use controller-tools 0.10.0. In version 0.9+ of controller-tools, an upstream patch removed the status sub-resource from the CustomResourceDefinition (CRD) for a...CRD. That's right, the "kind: CustomResourceDefinition" no longer has a status sub-resource, and that's why all of the manifests have been touched during this patch. For more info, please see kubernetes-sigs/controller-tools#630.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's tricky to get the existing CRD types to not include the status,
so we instead allow for filtering of the map just before writing.
Issue #456