Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨ Bump k8s to Kubernetes v1.25.0-alpha.3 #708

Conversation

laxmikantbpandhare
Copy link
Member

@laxmikantbpandhare laxmikantbpandhare commented Jul 22, 2022

Update k8s versions to v1.25.0-alpha.3

This will fix #707

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jul 22, 2022
@k8s-ci-robot
Copy link
Contributor

Welcome @laxmikantbpandhare!

It looks like this is your first PR to kubernetes-sigs/controller-tools 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-sigs/controller-tools has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Jul 22, 2022
@k8s-ci-robot
Copy link
Contributor

Hi @laxmikantbpandhare. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Jul 22, 2022
@laxmikantbpandhare laxmikantbpandhare changed the title ✨ Bump k8s to Kubernetes v1.25.0-alpha.3 #707 ✨ Bump k8s to Kubernetes v1.25.0-alpha.3 Jul 22, 2022
@varshaprasad96
Copy link
Member

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jul 22, 2022
@FillZpp
Copy link
Contributor

FillZpp commented Jul 25, 2022

LG, but why should we bump to v1.25.0 in such a hurry? It is still in alpha stage and I think controller-tools shouldn't release a new version with Kubernetes alpha dependencies, right?

@varshaprasad96
Copy link
Member

@FillZpp The idea is to bump k8s to latest alpha and be aware of any breaking changes. This is to make sure that when 1.25 stable is released we can bump the deps quicker. We aren't expecting controller-tools to cut a release with alpha dependencies. This would just get merged into master, and we will wait for stable k8s to be out to cut a release. (Fortunately, looks like there are no breaking changes, but I guess merging alpha to master should be fine).

Copy link
Member

@varshaprasad96 varshaprasad96 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 25, 2022
@laxmikantbpandhare
Copy link
Member Author

/assign @alvaroaleman

@varshaprasad96
Copy link
Member

@alvaroaleman @FillZpp can we move forward with this?

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: alvaroaleman, laxmikantbpandhare, varshaprasad96

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 28, 2022
@k8s-ci-robot k8s-ci-robot merged commit e65526e into kubernetes-sigs:master Jul 28, 2022
@laxmikantbpandhare
Copy link
Member Author

thank you @varshaprasad96 @alvaroaleman

@laxmikantbpandhare laxmikantbpandhare deleted the bump-k8s-v1.25.0-alpha.3 branch July 29, 2022 19:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bump k8s to Kubernetes v1.25.0-alpha.3
5 participants