-
Notifications
You must be signed in to change notification settings - Fork 420
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
✨ Bump k8s to Kubernetes v1.25.0-alpha.3 #708
✨ Bump k8s to Kubernetes v1.25.0-alpha.3 #708
Conversation
Welcome @laxmikantbpandhare! |
Hi @laxmikantbpandhare. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/ok-to-test |
LG, but why should we bump to v1.25.0 in such a hurry? It is still in alpha stage and I think controller-tools shouldn't release a new version with Kubernetes alpha dependencies, right? |
@FillZpp The idea is to bump k8s to latest alpha and be aware of any breaking changes. This is to make sure that when 1.25 stable is released we can bump the deps quicker. We aren't expecting controller-tools to cut a release with alpha dependencies. This would just get merged into master, and we will wait for stable k8s to be out to cut a release. (Fortunately, looks like there are no breaking changes, but I guess merging alpha to master should be fine). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/assign @alvaroaleman |
@alvaroaleman @FillZpp can we move forward with this? |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: alvaroaleman, laxmikantbpandhare, varshaprasad96 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
thank you @varshaprasad96 @alvaroaleman |
Update k8s versions to v1.25.0-alpha.3
This will fix #707