Enable and fix perfsprint linter
#1415
Conversation
k8s-ci-robot
added
kind/cleanup
k8s-ci-robot
added
the
size/L
cmd/crictl/container.go
Outdated
| return errors.New("Cannot checkpoint a container without specifying the checkpoint destination. " + | ||
| "Use --export=/path/to/checkpoint.tar", |
There was a problem hiding this comment.
The original line break here is better and more readable. We should keep it.
There was a problem hiding this comment.
True, reverted that particular change.
|
/approve |
|
@kwilczynski: changing LGTM is restricted to collaborators In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Signed-off-by: Sascha Grunert <sgrunert@redhat.com>
saschagrunert
force-pushed
the
perfsprint
branch
from
d925e2e to
ee2e56e
Compare
|
/lgtm |
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: feiskyer, kwilczynski, saschagrunert The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What type of PR is this?
/kind cleanup
What this PR does / why we need it:
Enable the linter and fix the reports.
Which issue(s) this PR fixes:
None
Special notes for your reviewer:
None
Does this PR introduce a user-facing change?