Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update golangci-lint to v1.62.2 #1718

Merged
merged 1 commit into from
Dec 9, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions .golangci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -47,6 +47,7 @@ linters:
- gosmopolitan
- govet
- grouper
- iface
- importas
- inamedparam
- ineffassign
Expand All @@ -71,6 +72,7 @@ linters:
- promlinter
- protogetter
- reassign
- recvcheck
- revive
- rowserrcheck
- sloglint
Expand Down
2 changes: 1 addition & 1 deletion Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -52,7 +52,7 @@ define curl_to
endef

ZEITGEIST_VERSION = v0.5.3
GOLANGCI_LINT_VERSION := v1.61.0
GOLANGCI_LINT_VERSION := v1.62.2
REPO_INFRA_VERSION = v0.2.5

GINKGO := $(BUILD_BIN_PATH)/ginkgo
Expand Down
2 changes: 1 addition & 1 deletion dependencies.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@ dependencies:
match: ZEITGEIST_VERSION

- name: golangci-lint
version: v1.61.0
version: v1.62.2
refPaths:
- path: Makefile
match: GOLANGCI_LINT_VERSION
Expand Down
2 changes: 1 addition & 1 deletion pkg/validate/networking.go
Original file line number Diff line number Diff line change
Expand Up @@ -273,7 +273,7 @@ func checkMainPage(c internalapi.RuntimeService, podID string, hostPort, contain
defer resp.Body.Close()
respChan <- resp
return nil
}, time.Minute, time.Second).Should(BeNil())
}, time.Minute, time.Second).Should(Succeed())

resp := <-respChan
Expect(resp.StatusCode).To(Equal(200), "The status code of response should be 200.")
Expand Down
2 changes: 1 addition & 1 deletion pkg/validate/security_context_linux.go
Original file line number Diff line number Diff line change
Expand Up @@ -1400,7 +1400,7 @@ func createAndCheckHostNetwork(rc internalapi.RuntimeService, ic internalapi.Ima
return fmt.Errorf("host port %s should be in container's port list", hostNetworkPort)
}
return nil
}, time.Minute, time.Second).Should(BeNil())
}, time.Minute, time.Second).Should(Succeed())

return podID, podLogDir
}
Expand Down
Loading