cmd/critest: fix empty ginkgo flag's value issue #930
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
do-not-merge/invalid-commit-message
In commit 53ad8bb[1], the ginkgo uses flags.StringVar for some flags, for instance, the --skip or --focus. But in the following release of ginkgo(>=v1.15.0[2]), the ginkgo starts to use string slice instead of the StringVar, which means we can't get the user's input by the flags.Value.String()[3]. The String() always returns empty value. Based on that, we should use ginkgo API to generate flags instead of manually handler in cri-test. Reference: [1]: https://github.com/kubernetes-sigs/cri-tools/blob/53ad8bb7f97e1b1d1c0c0634e43a3c2b8b07b718/vendor/github.com/onsi/ginkgo/config/config.go L79 [2]: https://github.com/onsi/ginkgo/blob/v1.15.0/config/config.go L84 [3]: https://github.com/onsi/ginkgo/blob/v1.15.0/config/config.go L68-L71 Signed-off-by: Wei Fu <fuweid89@gmail.com>
fuweid
force-pushed
the
support-string-slice-var
branch
from
651ff15 to
d4fe3e7
Compare
k8s-ci-robot
removed
the
do-not-merge/invalid-commit-message
|
My local test result is like Both the skip and parallel mode are working. |
|
/retest |
|
@fuweid: Cannot trigger testing until a trusted user reviews the PR and leaves an In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
Ping @feiskyer @saschagrunert |
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: fuweid, saschagrunert The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
Closed
psschwei
added a commit
to psschwei/containerd
that referenced
this pull request
May 12, 2022
Signed-off-by: Paul S. Schweigert <paulschw@us.ibm.com> As discussed in containerd#6903, running ginkgo tests in parallel while trying to skip wasn't working. However, now that kubernetes-sigs/cri-tools#930 has fixed the issue upstream, we can revert back to running our tests in parallel with the skip.
psschwei
added a commit
to psschwei/containerd
that referenced
this pull request
May 12, 2022
Signed-off-by: Paul S. Schweigert <paulschw@us.ibm.com> As discussed in containerd#6903, running ginkgo tests in parallel while trying to skip wasn't working. However, now that kubernetes-sigs/cri-tools#930 has fixed the issue upstream, we can revert back to running our tests in parallel with the skip.
psschwei
added a commit
to psschwei/containerd
that referenced
this pull request
May 12, 2022
Signed-off-by: Paul S. Schweigert <paulschw@us.ibm.com> As discussed in containerd#6903, running ginkgo tests in parallel while trying to skip wasn't working. However, now that kubernetes-sigs/cri-tools#930 has fixed the issue upstream, we can revert back to running our tests in parallel with the skip.
psschwei
added a commit
to psschwei/containerd
that referenced
this pull request
May 12, 2022
Signed-off-by: Paul S. Schweigert <paulschw@us.ibm.com> As discussed in containerd#6903, running ginkgo tests in parallel while trying to skip wasn't working. However, now that kubernetes-sigs/cri-tools#930 has fixed the issue upstream, we can revert back to running our tests in parallel with the skip.
psschwei
added a commit
to psschwei/containerd
that referenced
this pull request
May 12, 2022
Signed-off-by: Paul S. Schweigert <paulschw@us.ibm.com> As discussed in containerd#6903, running ginkgo tests in parallel while trying to skip wasn't working. However, now that kubernetes-sigs/cri-tools#930 has fixed the issue upstream, we can revert back to running our tests in parallel with the skip. Signed-off-by: Paul S. Schweigert <paulschw@us.ibm.com>
psschwei
added a commit
to psschwei/containerd
that referenced
this pull request
May 12, 2022
Signed-off-by: Paul S. Schweigert <paulschw@us.ibm.com> (cherry picked from commit 7300296) As discussed in containerd#6903, running ginkgo tests in parallel while trying to skip wasn't working. However, now that kubernetes-sigs/cri-tools#930 has fixed the issue upstream, we can revert back to running our tests in parallel with the skip. Signed-off-by: Paul S. Schweigert <paulschw@us.ibm.com>
psschwei
added a commit
to psschwei/containerd
that referenced
this pull request
May 12, 2022
Signed-off-by: Paul S. Schweigert <paulschw@us.ibm.com> (cherry picked from commit 7300296) As discussed in containerd#6903, running ginkgo tests in parallel while trying to skip wasn't working. However, now that kubernetes-sigs/cri-tools#930 has fixed the issue upstream, we can revert back to running our tests in parallel with the skip. Signed-off-by: Paul S. Schweigert <paulschw@us.ibm.com>
kiashok
pushed a commit
to kiashok/containerd-containerd
that referenced
this pull request
Oct 23, 2024
Signed-off-by: Paul S. Schweigert <paulschw@us.ibm.com> As discussed in containerd#6903, running ginkgo tests in parallel while trying to skip wasn't working. However, now that kubernetes-sigs/cri-tools#930 has fixed the issue upstream, we can revert back to running our tests in parallel with the skip.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind bug
What this PR does / why we need it:
In commit 53ad8bb 1, the ginkgo uses
flags.StringVar for some flags, for instance, the --skip or --focus.
But in the following release of ginkgo(>=v1.15.0 2), the ginkgo starts to
use string slice instead of the StringVar, which means we can't get the
user's input by the flags.Value.String() 3. The String() always returns
empty value.
Based on that, we should use ginkgo API to generate flags instead of
manually handler in cri-test.
Which issue(s) this PR fixes:
Fixes: #925
Special notes for your reviewer:
Does this PR introduce a user-facing change?