Skip to content
This repository has been archived by the owner on Jul 7, 2023. It is now read-only.

Compile with netgo to enable DNS resolution #40

Merged
merged 1 commit into from
Feb 1, 2021

Conversation

Sh4d1
Copy link
Member

@Sh4d1 Sh4d1 commented Jan 28, 2021

Signed-off-by: Patrik Cyvoct patrik@ptrk.io

Fixes #39

Signed-off-by: Patrik Cyvoct <patrik@ptrk.io>
@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jan 28, 2021
@k8s-ci-robot k8s-ci-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Jan 28, 2021
@Sh4d1
Copy link
Member Author

Sh4d1 commented Jan 28, 2021

/assign @maciaszczykm
Could we release a new version if this gets merged?

@jeefy
Copy link
Member

jeefy commented Jan 28, 2021

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jeefy, Sh4d1

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 28, 2021
@Sh4d1
Copy link
Member Author

Sh4d1 commented Feb 1, 2021

@jeefy can it be merged? Or waiting for another review? :)

@jeefy
Copy link
Member

jeefy commented Feb 1, 2021

/lgtm
I usually give courtesy time before I both lgtm and approve in case someone else has an opinion :)

@k8s-ci-robot k8s-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Feb 1, 2021
@k8s-ci-robot k8s-ci-robot merged commit e3bbe4c into kubernetes-sigs:master Feb 1, 2021
@Sh4d1
Copy link
Member Author

Sh4d1 commented Feb 1, 2021

Fair enough 😄 thanks! Will it be possible to cut a release with just this change ? 😄

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm Indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

DNS resolution is failing in the container
4 participants