Skip to content

Commit

Permalink
Merge pull request #1221 from antoinedeschenes/fix-profile-span-attri…
Browse files Browse the repository at this point in the history
…bute

profile: fix span attribute typo
  • Loading branch information
k8s-ci-robot authored Aug 22, 2023
2 parents bb47210 + 3f0c06b commit 1d4dc57
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions pkg/framework/profile/profile.go
Original file line number Diff line number Diff line change
Expand Up @@ -304,7 +304,7 @@ func (d profileImpl) RunDeschedulePlugins(ctx context.Context, nodes []*v1.Node)
errs := []error{}
for _, pl := range d.deschedulePlugins {
var span trace.Span
ctx, span = tracing.Tracer().Start(ctx, pl.Name(), trace.WithAttributes(attribute.String("plugin", pl.Name()), attribute.String("prpfile", d.profileName), attribute.String("operation", tracing.DescheduleOperation)))
ctx, span = tracing.Tracer().Start(ctx, pl.Name(), trace.WithAttributes(attribute.String("plugin", pl.Name()), attribute.String("profile", d.profileName), attribute.String("operation", tracing.DescheduleOperation)))
defer span.End()
evicted := d.podEvictor.TotalEvicted()
// TODO: strategyName should be accessible from within the strategy using a framework
Expand Down Expand Up @@ -337,7 +337,7 @@ func (d profileImpl) RunBalancePlugins(ctx context.Context, nodes []*v1.Node) *f
errs := []error{}
for _, pl := range d.balancePlugins {
var span trace.Span
ctx, span = tracing.Tracer().Start(ctx, pl.Name(), trace.WithAttributes(attribute.String("plugin", pl.Name()), attribute.String("prpfile", d.profileName), attribute.String("operation", tracing.BalanceOperation)))
ctx, span = tracing.Tracer().Start(ctx, pl.Name(), trace.WithAttributes(attribute.String("plugin", pl.Name()), attribute.String("profile", d.profileName), attribute.String("operation", tracing.BalanceOperation)))
defer span.End()
evicted := d.podEvictor.TotalEvicted()
// TODO: strategyName should be accessible from within the strategy using a framework
Expand Down

0 comments on commit 1d4dc57

Please sign in to comment.