Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump dependencies to address CVE-2023-44487 #1264

Merged

Conversation

ingvagabund
Copy link
Contributor

There's no 1.27.7 release yet. So pinning the k8s deps to the latest release-1.27 head

@ingvagabund ingvagabund added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 16, 2023
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

Approval requirements bypassed by manually added approval.

This pull-request has been approved by:

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knelasevero
Copy link
Contributor

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 16, 2023
@ingvagabund
Copy link
Contributor Author

/retest-required

1 similar comment
@ingvagabund
Copy link
Contributor Author

/retest-required

@knelasevero
Copy link
Contributor

knelasevero commented Oct 17, 2023

Hey @ingvagabund , change all occurrences of kubernetes/pause to registry.k8s.io/pause and e2e in CI should be good. kubernetes/pause is not pullable anymore.

test/e2e/e2e_duplicatepods_test.go
89:                                             Image:           "registry.k8s.io/pause",

test/e2e/e2e_leaderelection_test.go
179:                                            Image:           "registry.k8s.io/pause",

test/e2e/e2e_toomanyrestarts_test.go
90:                                             Image:           "registry.k8s.io/pause",

test/e2e/e2e_test.go
73:                     Image:           "registry.k8s.io/pause",
334:                                    Image:           "registry.k8s.io/pause",
1339:                                           Image: "registry.k8s.io/pause",

test/run-e2e-tests.sh
36:    ${CONTAINER_ENGINE:-docker} pull registry.k8s.io/pause
37:    kind load docker-image registry.k8s.io/pause

Locally I was getting same errors, and with this change:

...
tead
    e2e_topologyspreadconstraint_test.go:153: Pods for test-rc-topology-spread-soft-constraint were distributed in line with max skew of 1
    e2e_test.go:1185: Waiting for test-rc-topology-spread-soft-constraint-violator RC pods to disappear, still 2 remaining
    e2e_test.go:1185: Waiting for test-rc-topology-spread-soft-constraint-violator RC pods to disappear, still 0 remaining
    e2e_test.go:1185: Waiting for test-rc-topology-spread-soft-constraint RC pods to disappear, still 4 remaining
    e2e_test.go:1185: Waiting for test-rc-topology-spread-soft-constraint RC pods to disappear, still 0 remaining
--- PASS: TestTopologySpreadConstraint (54.42s)
    --- PASS: TestTopologySpreadConstraint/test-rc-topology-spread-hard-constraint (27.16s)
    --- PASS: TestTopologySpreadConstraint/test-rc-topology-spread-soft-constraint (27.14s)
=== RUN   TestClientConnectionConfiguration
--- PASS: TestClientConnectionConfiguration (0.11s)
PASS
ok      sigs.k8s.io/descheduler/test/e2e        461.730s

@ingvagabund
Copy link
Contributor Author

/retest-required

@knelasevero
Copy link
Contributor

/lgtm

@a7i
Copy link
Contributor

a7i commented Oct 18, 2023

Does this need to be cherry-picked to 0.26/release-1.26?

@a7i
Copy link
Contributor

a7i commented Oct 18, 2023

/easycla

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Oct 18, 2023
@k8s-ci-robot k8s-ci-robot merged commit 8c46e2f into kubernetes-sigs:release-1.27 Oct 18, 2023
8 checks passed
@ingvagabund ingvagabund deleted the bump-deps-1.27 branch October 18, 2023 07:33
@ingvagabund
Copy link
Contributor Author

Does this need to be cherry-picked to 0.26/release-1.26?

Eventually. We are still evaluating. This might be only a partial fix.

@ingvagabund
Copy link
Contributor Author

Does this need to be cherry-picked to 0.26/release-1.26?

@a7i we should. However, we can fix this only partially. There's no golang 1.19 backport yet: golang/go#63417 (comment)

@ingvagabund
Copy link
Contributor Author

@a7i the least we can do: #1273

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants