Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(podlifetime): fix failed unittest #1334

Merged
merged 2 commits into from
Jan 5, 2024
Merged

fix(podlifetime): fix failed unittest #1334

merged 2 commits into from
Jan 5, 2024

Commits on Dec 28, 2023

  1. fix(podlifetime): fix failed unittest 

    1. correct desired pod creation time
    @xujihui1985
    xujihui1985 committed Dec 28, 2023
    Configuration menu
    Copy the full SHA
    ae7467f View commit details
    Browse the repository at this point in the history

Commits on Jan 3, 2024

  1. fix: filter pod with age greater than MaxPodLifeTimeSeconds 

    when the pod createtimestamp is greater than the current time (which is
not make sense in real life, but when doing test with such case,
it is possible), it will convert to a large number if we convert it
to uint, and though it can pass the test, but doesn't make sense.
    @xujihui1985
    xujihui1985 committed Jan 3, 2024
    Configuration menu
    Copy the full SHA
    5092595 View commit details
    Browse the repository at this point in the history