Move maximum-pods-per-nodes-evicted logic under a single invocation #266
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
cncf-cla: yes
|
@damemi @seanmalloy PTAL |
|
Integrating part of #161 as well. |
|
Also, if this PR gets merged first, #254 will need to be rebased. |
ingvagabund
force-pushed
the
pod-evictor
branch
from
c1d5fbc
to
990c21a
Compare
ingvagabund
force-pushed
the
pod-evictor
branch
from
990c21a
to
37fc1e7
Compare
seanmalloy
requested changes
Apr 22, 2020
Each strategy implements a test for checking if a maximum number of pods per node was already evicted. The test duplicates a code that can be put under a single invocation. Thus, reducing the number of arguments passed to each strategy given EvicPod call can encapsulate both the check and the invocation of the pod eviction itself.
ingvagabund
force-pushed
the
pod-evictor
branch
from
37fc1e7
to
077b7f6
Compare
seanmalloy
approved these changes
Apr 22, 2020
k8s-ci-robot
added
the
lgtm
|
/assign @ravisantoshgudimetla @aveshagarwal |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: aveshagarwal, ingvagabund The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
4 tasks
briend
pushed a commit
to briend/descheduler
that referenced
this pull request
Feb 11, 2022
Move maximum-pods-per-nodes-evicted logic under a single invocation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Each strategy implements a test for checking if a maximum number of pods per node was already evicted. The test duplicates a code that can be put under a single invocation. Thus, reducing the number of arguments passed to each strategy given EvictPod call can encapsulate both the check and the invocation of the pod eviction itself.