-
Notifications
You must be signed in to change notification settings - Fork 668
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update To Go 1.15.0 #371
Update To Go 1.15.0 #371
Conversation
/hold We should wait until the k/k repo is successfully updated to use Go 1.15.0. Also, the descheduler test-infra jobs for the master branch should be updated to use Go 1.15.0. |
The k/k repo has been updated with Go 1.15.0: kubernetes/kubernetes#93939. I believe this plan for the k8s 1.19 release is still to use Go 1.15.0. I believe all that needs to be done now for the descheduler is to update test-infra jobs to use Go 1.15. Then this PR can be retested and merged. |
Created PR kubernetes/test-infra#18836 to update the descheduler test-intra jobs to use Go 1.15. |
@seanmalloy is the code currently vendored in the descheduler buildable with go1.15? |
Yes, I was able to compile with go 1.15 and run "go mod vendor" and "go mod tidy". No changes to the vendor directory were made when updating from go 1.14 to go 1.15. |
I did notice that Error details:
|
I got a little bit closer. I had to update golangci-lint to 1.30.0 to make it work with Go 1.15. But now the new version of golangci-lint is failing with the below errors:
@ingvagabund @lixiang233 @damemi any ideas what I need to change to make the new version of golangci-lint happy? |
@seanmalloy This error haapens because I think we can refactor
|
@lixiang233 @seanmalloy let's drop the fake completely: #385 |
I will rebase this PR after #385 is merged. Then I think it might work. |
/retest |
1 similar comment
/retest |
As part of the k8s 1.19 release cycle the Go version is being bumped to 1.15.0. Updating the descheduler to use Go 1.15 prior to the descheduler v0.19.0 release. See below issues for reference: * kubernetes/release#1421 * kubernetes/kubernetes#93484
/hold cancel |
/lgtm |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/approve
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: damemi, seanmalloy The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Update To Go 1.15.0
As part of the k8s 1.19 release cycle the Go version is being bumped to
1.15.0. Updating the descheduler to use Go 1.15 prior to the descheduler
v0.19.0 release.
See below issues for reference: