Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP - New Strategy RemovePodsViolatingTopologySpreadConstraint #383

Closed
wants to merge 3 commits into from

Conversation

seanmalloy
Copy link
Member

@seanmalloy seanmalloy commented Aug 21, 2020

This is a work in progress. It does not work yet. Fixes #146.

This PR has three commits:

Task List:

  • Documentation
  • Unit Tests
  • New Code For Strategy

@k8s-ci-robot k8s-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Aug 21, 2020
@seanmalloy
Copy link
Member Author

/hold

@k8s-ci-robot k8s-ci-robot added do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Aug 21, 2020
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: seanmalloy
To complete the pull request process, please assign ravisantoshgudimetla
You can assign the PR to them by writing /assign @ravisantoshgudimetla in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@seanmalloy
Copy link
Member Author

I do not have time to finish off this PR. This was discussed during the SIG scheduling meeting today(August 27th). The commits in this PR can be used as a starting point for someone that has time to complete this feature.

/kind feature
/help

@k8s-ci-robot k8s-ci-robot added the kind/feature Categorizes issue or PR as related to a new feature. label Aug 28, 2020
@damemi
Copy link
Contributor

damemi commented Aug 31, 2020

Commented in #146 (comment), I'll pick up your commits in a new PR

@rhockenbury
Copy link

Any updates on this work?

@damemi
Copy link
Contributor

damemi commented Sep 28, 2020

Hi @rhockenbury, I'm working on this and will open a new PR for it soon (I got delayed from when I first commented that I'll pick it up, but now I have time to focus on it). It should be available in the v0.20 release of the descheduler.

Copy link
Contributor

@damemi damemi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/close
closing for new PR here: #413

@k8s-ci-robot
Copy link
Contributor

@damemi: Closed this PR.

In response to this:

/close
closing for new PR here: #413

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. kind/feature Categorizes issue or PR as related to a new feature. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Policy for Balancing Pods across topology domains
4 participants