Add Namespace filtering to RemoveDuplicates strategy #406
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
cncf-cla: yes
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: damemi The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
damemi
force-pushed
the
duplicates-namespace-filtering
branch
from
1200380
to
be0cc56
Compare
damemi
force-pushed
the
duplicates-namespace-filtering
branch
from
be0cc56
to
b9d73ec
Compare
ingvagabund
requested changes
Sep 20, 2020
README.md
Outdated
| @@ -188,8 +206,17 @@ This strategy makes sure that pods violating interpod anti-affinity are removed | |||
| if there is podA on a node and podB and podC (running on the same node) have anti-affinity rules which prohibit | |||
| them to run on the same node, then podA will be evicted from the node so that podB and podC could run. This | |||
| issue could happen, when the anti-affinity rules for podB and podC are created when they are already running on | |||
| node. Currently, there are no parameters associated with this strategy. To disable this strategy, the | |||
| policy should look like: | |||
| node. Currently, there are no parameters associated with this strategy. | |||
There was a problem hiding this comment.
Currently, there are no parameters associated with this strategy. not necessary here
There was a problem hiding this comment.
To disable this strategy, the policy should look like still applies here unless the example's enabled field is set to true
damemi
force-pushed
the
duplicates-namespace-filtering
branch
from
b9d73ec
to
1f02d87
Compare
|
/lgtm Holding for others to LGTM. Feel free to unhold. |
k8s-ci-robot
added
the
do-not-merge/hold
k8s-ci-robot
added
the
lgtm
lixiang233
reviewed
Sep 22, 2020
damemi
force-pushed
the
duplicates-namespace-filtering
branch
from
1f02d87
to
11b9829
Compare
k8s-ci-robot
removed
the
lgtm
|
/lgtm |
k8s-ci-robot
added
the
lgtm
|
/lgtm |
|
/hold cancel |
k8s-ci-robot
removed
the
do-not-merge/hold
|
/kind feature |
k8s-ci-robot
added
the
kind/feature
briend
pushed a commit
to briend/descheduler
that referenced
this pull request
Feb 11, 2022
…ce-filtering Add Namespace filtering to RemoveDuplicates strategy
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #405
This also adds a
parameterstable to each strategy for a quicker reference at what the params are available