-
Notifications
You must be signed in to change notification settings - Fork 668
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix Version Output For Automated Container Builds #427
Fix Version Output For Automated Container Builds #427
Conversation
Not quite done testing yet. /hold |
7ae3f9e
to
cf02022
Compare
Here is what the new output for Example for local builds and automated builds using a commit(not a tag):
Example for automated builds using a tag:
Example for automated builds using the helm chart tag. Yes, this is still broken:
|
/test pull-descheduler-verify-master |
/assign @damemi |
/hold cancel |
Also, tested the
and ...
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@seanmalloy looks like you've got it working, but as you mentioned in #427 (comment) this is obviously still going to print the wrong tag for automatic builds. So 2 questions: that shouldn't be a problem with images pulled from the published v0.19.0
tags right? And also, would there be a way to parse the semver out of the helm-chart
tag and use that?
@damemi see responses to your questions below.
Short answer, correct. I believe once this PR is merged the
My concern would be that we would be putting in helm chart version into the descheduler binary instead of the descheduler version. Let me know if you disagree. I don't have a great solution for this right now. |
@seanmalloy cool, I actually think the recent updates we made to the chart releaser action might fix our automatic releases (the new version of the action tags from the branch it's created from, which will keep it separate from master see #436 (review)).
Also btw, the tags can be created from the github UI when you create the release (this is how I've done the past couple releases 😉) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@seanmalloy this looks good to me if you just squash the commits
/approve
/hold
@ingvagabund can lgtm (and remove the hold)
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: damemi, seanmalloy The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
I'll squash commits after @ingvagabund reviews assuming there are not additional changes requested. |
Looks good, you can squash. I will lgtm right after. Thanks!!! |
Prior to this change the output from the command "descheduler version" when run using the official container images from k8s.gcr.io would always output an empty string. See below for an example. ``` docker run k8s.gcr.io/descheduler/descheduler:v0.19.0 /bin/descheduler version Descheduler version {Major: Minor: GitCommit: GitVersion: BuildDate:2020-09-01T16:43:23+0000 GoVersion:go1.15 Compiler:gc Platform:linux/amd64} ``` This change makes it possible to pass the descheduler version information to the automated container image build process and also makes it work for local builds too.
4cc5dc9
to
8795fe6
Compare
@ingvagabund commits have been squashed. |
/lgtm |
…on-output Fix Version Output For Automated Container Builds
Prior to this change the output from the command "descheduler version" when run using the official container images from k8s.gcr.io would always output an empty string. See below for an example.
This change makes it possible to pass the descheduler version information to the automated container image build process and also makes it work for local builds too.
Fixes #425