Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

OWNERS: add a7i as a reviewer #697

Merged
merged 1 commit into from
Feb 11, 2022
Merged

OWNERS: add a7i as a reviewer #697

merged 1 commit into from
Feb 11, 2022

Conversation

a7i
Copy link
Contributor

@a7i a7i commented Jan 18, 2022

Per @ingvagabund adding myself as a code reviewer

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jan 18, 2022
@k8s-ci-robot
Copy link
Contributor

Hi @a7i. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Jan 18, 2022
@a7i
Copy link
Contributor Author

a7i commented Jan 18, 2022

/assign ingvagabund

@k8s-ci-robot k8s-ci-robot added the do-not-merge/invalid-owners-file Indicates that a PR should not merge because it has an invalid OWNERS file in it. label Jan 18, 2022
damemi
damemi reviewed Jan 18, 2022
View reviewed changes
Copy link
Contributor

@damemi damemi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve
🎉 Thanks for everything you've done Amir!
We should also add you to the kubernetes-sigs org as the bot said. Feel free to open a PR there, I will +1 your nomination :)

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: a7i, damemi

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 18, 2022
@ingvagabund
Copy link
Contributor

/lgtm
/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. lgtm "Looks good to me", indicates that a PR is ready to be merged. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jan 18, 2022
@JaneLiuL
Copy link
Member

@a7i Congratulations~

@seanmalloy
Copy link
Member

/approve 🎉 Thanks for everything you've done Amir! We should also add you to the kubernetes-sigs org as the bot said. Feel free to open a PR there, I will +1 your nomination :)

@a7i any luck getting added to the kubernetes-sigs org? Let me know if you need any assistance with the process. Thanks!

@ingvagabund
Copy link
Contributor

/verify-owners

@a7i
Copy link
Contributor Author

a7i commented Feb 11, 2022

/verify-owners

Thank you for your patience!

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/invalid-owners-file Indicates that a PR should not merge because it has an invalid OWNERS file in it. label Feb 11, 2022
@damemi
Copy link
Contributor

damemi commented Feb 11, 2022

@a7i thank you for being so patient! Sorry about the confusion over the +1s... congrats and thank you for all of your help with the project so far :)

@k8s-ci-robot k8s-ci-robot merged commit 5901f8a into kubernetes-sigs:master Feb 11, 2022
@a7i a7i deleted the code-reviewer branch August 26, 2023 03:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@damemi damemi damemi left review comments

@aveshagarwal aveshagarwal Awaiting requested review from aveshagarwal

@ingvagabund ingvagabund Awaiting requested review from ingvagabund

Assignees

@ingvagabund ingvagabund

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@a7i @k8s-ci-robot @ingvagabund @JaneLiuL @seanmalloy @damemi