-
Notifications
You must be signed in to change notification settings - Fork 668
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
OWNERS: add a7i as a reviewer #697
Conversation
Hi @a7i. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/assign ingvagabund |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/approve
🎉 Thanks for everything you've done Amir!
We should also add you to the kubernetes-sigs org as the bot said. Feel free to open a PR there, I will +1 your nomination :)
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: a7i, damemi The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/lgtm |
@a7i Congratulations~ |
@a7i any luck getting added to the kubernetes-sigs org? Let me know if you need any assistance with the process. Thanks! |
/verify-owners |
/verify-owners Thank you for your patience! |
@a7i thank you for being so patient! Sorry about the confusion over the +1s... congrats and thank you for all of your help with the project so far :) |
Per @ingvagabund adding myself as a code reviewer