-
Notifications
You must be signed in to change notification settings - Fork 668
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: add imagePullSecrets for deployment resource #716
fix: add imagePullSecrets for deployment resource #716
Conversation
Signed-off-by: emin.aktas <eminaktas34@gmail.com> Co-authored-by: yasintahaerol <yasintahaerol@gmail.com> Co-authored-by: Dentrax <furkan.turkal@trendyol.com>
Hi @eminaktas. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/ok-to-test
@@ -27,6 +27,10 @@ spec: | |||
priorityClassName: {{ .Values.priorityClassName }} | |||
{{- end }} | |||
serviceAccountName: {{ template "descheduler.serviceAccountName" . }} | |||
{{- with .Values.imagePullSecrets }} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not an expert on the helm chart syntax, how does with
handle empty values? Everywhere else we have been using if
, but if the behavior is the same then it's probably fine
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't play with the helm much but I used it the same way as in cronjob.yaml. It is basically like an if. Also, I already tested locally for the below cases, it worked as expected.
imagePullSecrets:
imagePullSecrets: []
imagePullSecrets:
- name: container-registry-secret
Ref:
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: damemi, eminaktas, liangyuanpeng The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Signed-off-by: emin.aktas eminaktas34@gmail.com
Co-authored-by: yasintahaerol yasintahaerol@gmail.com
Co-authored-by: Dentrax furkan.turkal@trendyol.com