Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[e2e] TestTooManyRestarts: check if container status is set before accessing #761

Merged

Conversation

ingvagabund
Copy link
Contributor

From https://prow.k8s.io/view/gs/kubernetes-jenkins/pr-logs/pull/kubernetes-sigs_descheduler/759/pull-descheduler-test-e2e-k8s-master-1-23/1502212010236973056:

=== RUN   TestTooManyRestarts
    e2e_toomanyrestarts_test.go:50: Creating testing namespace TestTooManyRestarts
    e2e_toomanyrestarts_test.go:86: Creating deployment restart-pod
--- FAIL: TestTooManyRestarts (5.14s)
panic: runtime error: index out of range [0] with length 0 [recovered]
	panic: runtime error: index out of range [0] with length 0
goroutine 1222 [running]:
testing.tRunner.func1.2({0x1c01380, 0xc00140ac78})
	/usr/local/go/src/testing/testing.go:1209 +0x24e
testing.tRunner.func1()
	/usr/local/go/src/testing/testing.go:1212 +0x218
panic({0x1c01380, 0xc00140ac78})
	/usr/local/go/src/runtime/panic.go:1038 +0x215
sigs.k8s.io/descheduler/test/e2e.waitPodRestartCount({0x1fc4f90, 0xc000140000}, {0x2026a90, 0xc0001b4d80}, {0xc000c65e78, 0x17}, 0xc0013869c0)
	/home/prow/go/src/github.com/kubernetes-sigs/descheduler/test/e2e/e2e_toomanyrestarts_test.go:194 +0x53a
sigs.k8s.io/descheduler/test/e2e.TestTooManyRestarts(0xc0013869c0)
	/home/prow/go/src/github.com/kubernetes-sigs/descheduler/test/e2e/e2e_toomanyrestarts_test.go:100 +0xbb2
testing.tRunner(0xc0013869c0, 0x1e01da8)
	/usr/local/go/src/testing/testing.go:1259 +0x102
created by testing.(*T).Run
	/usr/local/go/src/testing/testing.go:1306 +0x35a
FAIL	sigs.k8s.io/descheduler/test/e2e	301.469s

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Mar 11, 2022
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ingvagabund

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Mar 11, 2022
@ingvagabund
Copy link
Contributor Author

/retest

@JaneLiuL
Copy link
Member

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 11, 2022
@k8s-ci-robot k8s-ci-robot merged commit 0e0ae8d into kubernetes-sigs:master Mar 11, 2022
@ingvagabund ingvagabund deleted the TestTooManyRestarts-II branch March 11, 2022 10:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants