Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update release guide docs #818

Merged
merged 1 commit into from
May 26, 2022
Merged

Update release guide docs #818

merged 1 commit into from
May 26, 2022

Conversation

damemi
Copy link
Contributor

@damemi damemi commented May 25, 2022

Updating the release guide with the new flowchart and steps, including pre-release code changes

@damemi damemi requested a review from seanmalloy May 25, 2022 15:37
@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label May 25, 2022
@k8s-ci-robot k8s-ci-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label May 25, 2022
damemi
damemi commented May 25, 2022
View reviewed changes
Copy link
Contributor Author

@damemi damemi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/cc @seanmalloy @ingvagabund @JaneLiuL ptal

docs/release-guide.md
@@ -1,36 +1,79 @@
# Release Guide

## Container Image

### Semi-automatic
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the semi-automatic and manual image pushing steps were all the same except for the command to manually push, so I removed these sections and added a note that it can be manually pushed instead

@k8s-ci-robot
Copy link
Contributor

@damemi: GitHub didn't allow me to request PR reviews from the following users: ptal.

Note that only kubernetes-sigs members and repo collaborators can review this PR, and authors cannot review their own PRs.

In response to this:

/cc @seanmalloy @ingvagabund @JaneLiuL ptal

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

JaneLiuL
JaneLiuL reviewed May 26, 2022
View reviewed changes
Copy link
Member

@JaneLiuL JaneLiuL left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 26, 2022
@damemi
Copy link
Contributor Author

damemi commented May 26, 2022

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: damemi

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 26, 2022
@k8s-ci-robot k8s-ci-robot merged commit 5a9e658 into kubernetes-sigs:master May 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JaneLiuL JaneLiuL JaneLiuL left review comments

@seanmalloy seanmalloy Awaiting requested review from seanmalloy

@aveshagarwal aveshagarwal Awaiting requested review from aveshagarwal

@lixiang233 lixiang233 Awaiting requested review from lixiang233

@ingvagabund ingvagabund Awaiting requested review from ingvagabund

Assignees

@JaneLiuL JaneLiuL

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@damemi @k8s-ci-robot @JaneLiuL