separate args validation for better reuse

[a7i]

1. Separate validations for reuse
2. Aggregate all errors as opposed to stopping on first validation error

[a7i]

/cc @damemi @ingvagabund

[damemi]

Thanks for doing this work @a7i, but this change wasn't really my intent with the comment in #861 (comment). The point I'm trying to get at more is that our default plugins shouldn't be any different from theoretical third-party plugins. So, not dependent on any internal functions like this.

In my other comment, I meant more that Namespace and Label arg validation should be public, common functions that we export as part of the framework (to be used by any plugins). Does that make sense?

[a7i]

In my other comment, I meant more that Namespace and Label arg validation should be public, common functions that we export as part of the framework (to be used by any plugins). Does that make sense?

So basically move the new functions to a new file and make them public. Do you have a place in mind that will fit this?
same directory i.e. pkg/apis/componentconfig/validation seems good?

[damemi]

@a7i I think for now they can stay where they are, I just wanted to make a note of my intent for these eventually. Breaking them into individual functions works toward that goal so this PR looks fine to me. Sorry for the confusion
/lgtm

[damemi]

/approve

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: damemi

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [damemi]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment