Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add RemovePodsHavingTooManyRestarts to values.yaml #945

Merged
merged 1 commit into from
Sep 8, 2022
Merged

feat: add RemovePodsHavingTooManyRestarts to values.yaml #945

merged 1 commit into from
Sep 8, 2022

Conversation

gallowaystorm
Copy link
Contributor

This does the following:

  1. Enables RemovePodsHavingTooManyRestarts when using Helm by default (it is not currently)
  2. Adds RemovePodsHavingTooManyRestarts to the values.yaml for clearer configs

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Sep 7, 2022
@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Sep 7, 2022
@k8s-ci-robot
Copy link
Contributor

Hi @gallowaystorm. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Sep 7, 2022
@gallowaystorm gallowaystorm changed the title feat: add RemovePodsHavingTooManyRestarts to yaml feat: add RemovePodsHavingTooManyRestarts to values.yaml Sep 7, 2022
@a7i
Copy link
Contributor

a7i commented Sep 7, 2022

/ok-to-test
/lgtm

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Sep 7, 2022
@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 7, 2022
@gallowaystorm
Copy link
Contributor Author

@a7i Why did the Helm lint test fail? I checked and I don't see any error messages. Just that the test "TestLowNodeUtilization" failed...

@a7i
Copy link
Contributor

a7i commented Sep 7, 2022

/retest

@a7i
Copy link
Contributor

a7i commented Sep 7, 2022 •
edited
Loading

🤕 looks like GitHub Actions don't re-run on slash commands and I don't have access to restart it. Could you please push your commit again to force a rebuild?

@gallowaystorm
feat: add RemovePodsHavingTooManyRestarts to yaml
d14df1f 
This does the following:
1. Enables RemovePodsHavingTooManyRestarts when using Helm by default (it is not currently)
2. Adds RemovePodsHavingTooManyRestarts to the values.yaml for clearer configs
@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 7, 2022
@gallowaystorm
Copy link
Contributor Author

🤕 looks like GitHub Actions don't re-run on slash commands and I don't have access to restart it. Could you please push your commit again to force a rebuild?

done

@a7i
Copy link
Contributor

a7i commented Sep 7, 2022

Thank you 🏅

/approve
/assign @JaneLiuL

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: a7i

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 7, 2022
@a7i a7i mentioned this pull request Sep 7, 2022
Closed
JaneLiuL
JaneLiuL reviewed Sep 8, 2022
View reviewed changes
Copy link
Member

@JaneLiuL JaneLiuL left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
thanks @gallowaystorm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 8, 2022
@k8s-ci-robot k8s-ci-robot merged commit d8bac08 into kubernetes-sigs:master Sep 8, 2022
@gallowaystorm gallowaystorm deleted the patch-1 branch September 12, 2022 14:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JaneLiuL JaneLiuL JaneLiuL left review comments

@a7i a7i Awaiting requested review from a7i

@lixiang233 lixiang233 Awaiting requested review from lixiang233

Assignees

@a7i a7i

@JaneLiuL JaneLiuL

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@gallowaystorm @k8s-ci-robot @a7i @JaneLiuL