-
Notifications
You must be signed in to change notification settings - Fork 668
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: change DeschedulerVersion and GitVersion labels #947
feat: change DeschedulerVersion and GitVersion labels #947
Conversation
Hi @eminaktas. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
cc @damemi |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/ok-to-test
since this is an alpha metric, I think we can technically change what the labels are reporting. But it may still be confusing that the DeschedulerVersion
label is different now to anyone who was using that.
Maybe add this to a new label (instead of updating the existing one), like AppVersion
?
This commit changes build_info metric labels - AppVersion label will show major+minor version for example 0.24.1 minor version numbers and commit hash Signed-off-by: eminaktas <eminaktas34@gmail.com>
d66e1ac
to
2c17af7
Compare
You are right. I just updated the PR. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/approve
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: damemi The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/lgtm thank you @eminaktas 🏆 |
This commit changes build_info metric labels
It will be seen like this
Signed-off-by: eminaktas eminaktas34@gmail.com