Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: change DeschedulerVersion and GitVersion labels #947

Merged
merged 1 commit into from
Sep 12, 2022

Conversation

eminaktas
Copy link
Contributor

@eminaktas eminaktas commented Sep 8, 2022

This commit changes build_info metric labels

  • AppVersion label will show major+minor version for example 0.24.1

It will be seen like this

# HELP descheduler_build_info [ALPHA] Build info about descheduler, including Go version, Descheduler version, Git SHA, Git branch
# TYPE descheduler_build_info gauge
descheduler_build_info{AppVersion="0.24.1",GitBranch="metric-label-fix",GitSha1="0317be1b7672c511f5e2e53acaea1dd5cb74fd77",DeschedulerVersion="v20220909-v0.24.1-188-g0317be1b7",GoVersion="go1.19"} 0

Signed-off-by: eminaktas eminaktas34@gmail.com

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Sep 8, 2022
@k8s-ci-robot
Copy link
Contributor

Hi @eminaktas. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Sep 8, 2022
@eminaktas
Copy link
Contributor Author

cc @damemi

Copy link
Contributor

@damemi damemi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/ok-to-test
since this is an alpha metric, I think we can technically change what the labels are reporting. But it may still be confusing that the DeschedulerVersion label is different now to anyone who was using that.

Maybe add this to a new label (instead of updating the existing one), like AppVersion?

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Sep 12, 2022
This commit changes build_info metric labels
- AppVersion label will show major+minor version
  for example 0.24.1
  minor version numbers and commit hash

Signed-off-by: eminaktas <eminaktas34@gmail.com>
@eminaktas
Copy link
Contributor Author

/ok-to-test since this is an alpha metric, I think we can technically change what the labels are reporting. But it may still be confusing that the DeschedulerVersion label is different now to anyone who was using that.

Maybe add this to a new label (instead of updating the existing one), like AppVersion?

You are right. I just updated the PR.

Copy link
Contributor

@damemi damemi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: damemi

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 12, 2022
@a7i
Copy link
Contributor

a7i commented Sep 12, 2022

/lgtm

thank you @eminaktas 🏆

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 12, 2022
@k8s-ci-robot k8s-ci-robot merged commit 82ed18f into kubernetes-sigs:master Sep 12, 2022
@eminaktas eminaktas deleted the metric-label-fix branch September 12, 2022 19:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants