Merge pull request #471 from jbdoumenjou/fix-gatewayclass-default-status

fix GatewayClassStatus default value
kubernetes-sigs · Nov 23, 2020 · 51f266f · 51f266f
2 parents 3015e30 + c26755e
commit 51f266f
Show file tree

Hide file tree

Showing 4 changed files with 21 additions and 21 deletions.
diff --git a/apis/v1alpha1/gatewayclass_types.go b/apis/v1alpha1/gatewayclass_types.go
@@ -42,7 +42,7 @@ type GatewayClass struct {
 	// Spec for this GatewayClass.
 	Spec GatewayClassSpec `json:"spec,omitempty"`
 	// Status of the GatewayClass.
-	// +kubebuilder:default={conditions: {{type: "InvalidParameters", status: "Unknown", message: "Waiting for controller", reason: "Waiting", lastTransitionTime: "1970-01-01T00:00:00Z"}}}
+	// +kubebuilder:default={conditions: {{type: "Admitted", status: "False", message: "Waiting for controller", reason: "Waiting", lastTransitionTime: "1970-01-01T00:00:00Z"}}}
 	Status GatewayClassStatus `json:"status,omitempty"`
 }
 

diff --git a/config/crd/bases/networking.x-k8s.io_gatewayclasses.yaml b/config/crd/bases/networking.x-k8s.io_gatewayclasses.yaml
diff --git a/docs-src/gatewayclass.md b/docs-src/gatewayclass.md
@@ -79,23 +79,23 @@ kind: GatewayClass
 ...
 status:
   conditions:
-  - type: InvalidParameters
-    status: Unknown
+  - type: Admitted
+    status: False
     ...
 ```
 
-A new `GatewayClass` will start with the `InvalidParameters` condition set to
-`Unknown`. At this point the controller has not seen the configuration. Once the
+A new `GatewayClass` will start with the `Admitted` condition set to
+`False`. At this point the controller has not seen the configuration. Once the
 controller has processed the configuration, the condition will be set to
-`False`:
+`True`:
 
 ```yaml
 kind: GatewayClass
 ...
 status:
   conditions:
-  - type: InvalidParameters
-    status: False
+  - type: Admitted
+    status: True
     ...
 ```
 
@@ -107,8 +107,8 @@ kind: GatewayClass
 ...
 status:
   conditions:
-  - type: InvalidParameters
-    status: True
+  - type: Admitted
+    status: False
     Reason: BadFooBar
     Message: "foobar" is an FooBar.
 ```

diff --git a/docs/gatewayclass/index.html b/docs/gatewayclass/index.html
@@ -686,21 +686,21 @@ <h3 id="gatewayclass-status">GatewayClass status</h3>
 ...
 status:
   conditions:
-  - type: InvalidParameters
-    status: Unknown
+  - type: Admitted
+    status: False
     ...
 </code></pre>
 
-<p>A new <code>GatewayClass</code> will start with the <code>InvalidParameters</code> condition set to
-<code>Unknown</code>. At this point the controller has not seen the configuration. Once the
+<p>A new <code>GatewayClass</code> will start with the <code>Admitted</code> condition set to
+<code>False</code>. At this point the controller has not seen the configuration. Once the
 controller has processed the configuration, the condition will be set to
-<code>False</code>:</p>
+<code>True</code>:</p>
 <pre><code class="yaml">kind: GatewayClass
 ...
 status:
   conditions:
-  - type: InvalidParameters
-    status: False
+  - type: Admitted
+    status: True
     ...
 </code></pre>
 
@@ -710,8 +710,8 @@ <h3 id="gatewayclass-status">GatewayClass status</h3>
 ...
 status:
   conditions:
-  - type: InvalidParameters
-    status: True
+  - type: Admitted
+    status: False
     Reason: BadFooBar
     Message: &quot;foobar&quot; is an FooBar.
 </code></pre>