Add validation for Kubernetes object name fields and ProtocolType

Signed-off-by: Nick Young <ynick@vmware.com>

apis/v1alpha2/gateway_types.go

@@ -63,10 +63,7 @@ type GatewayList struct {
 type GatewaySpec struct {
 	// GatewayClassName used for this Gateway. This is the name of a
 	// GatewayClass resource.
-	//
-	// +kubebuilder:validation:MinLength=1
-	// +kubebuilder:validation:MaxLength=253
-	GatewayClassName string `json:"gatewayClassName"`
+	GatewayClassName ObjectName `json:"gatewayClassName"`
 
 	// Listeners associated with this Gateway. Listeners define
 	// logical endpoints that are bound on this Gateway's addresses.
@@ -247,6 +244,10 @@ type Listener struct {
 // `mycompany.com/my-custom-protocol`. Un-prefixed names are reserved for core
 // protocols. Any protocol defined by implementations will fall under custom
 // conformance.
+//
+// +kubebuilder:validation:MinLength:=1
+// +kubebuilder:validation:MinLength:=255
+// +kubebuilder:validation:Pattern:=`^[a-zA-Z0-9]([A-Z-a-z0-9\/]*[A-Za-z0-9])?(\.[A-Za-z0-9]([A-Z-a-z0-9\/]*[A-Za-z0-9])?)*$`
 type ProtocolType string
 
 const (

apis/v1alpha2/object_reference_types.go

@@ -27,10 +27,7 @@ type LocalObjectReference struct {
 	Kind Kind `json:"kind"`
 
 	// Name is the name of the referent.
-	//
-	// +kubebuilder:validation:MinLength=1
-	// +kubebuilder:validation:MaxLength=253
-	Name string `json:"name"`
+	Name ObjectName `json:"name"`
 }
 
 // SecretObjectReference identifies an API object including its namespace, defaulting to Secret.
@@ -49,10 +46,7 @@ type SecretObjectReference struct {
 	Kind *Kind `json:"kind"`
 
 	// Name is the name of the referent.
-	//
-	// +kubebuilder:validation:MinLength=1
-	// +kubebuilder:validation:MaxLength=253
-	Name string `json:"name"`
+	Name ObjectName `json:"name"`
 
 	// Namespace is the namespace of the backend. When unspecified, the local
 	// namespace is inferred.
@@ -91,10 +85,7 @@ type BackendObjectReference struct {
 	Kind *Kind `json:"kind,omitempty"`
 
 	// Name is the name of the referent.
-	//
-	// +kubebuilder:validation:MinLength=1
-	// +kubebuilder:validation:MaxLength=253
-	Name string `json:"name"`
+	Name ObjectName `json:"name"`
 
 	// Namespace is the namespace of the backend. When unspecified, the local
 	// namespace is inferred.

apis/v1alpha2/policy_types.go

@@ -29,10 +29,7 @@ type PolicyTargetReference struct {
 	Kind Kind `json:"kind"`
 
 	// Name is the name of the target resource.
-	//
-	// +kubebuilder:validation:MinLength=1
-	// +kubebuilder:validation:MaxLength=253
-	Name string `json:"name"`
+	Name ObjectName `json:"name"`
 
 	// Namespace is the namespace of the referent. When unspecified, the local
 	// namespace is inferred. Even when policy targets a resource in a different

apis/v1alpha2/shared_types.go

@@ -67,10 +67,7 @@ type ParentRef struct {
 	// Name is the name of the referent.
 	//
 	// Support: Core
-	//
-	// +kubebuilder:validation:MinLength=1
-	// +kubebuilder:validation:MaxLength=253
-	Name string `json:"name"`
+	Name ObjectName `json:"name"`
 
 	// SectionName is the name of a section within the target resource. In the
 	// following resources, SectionName is interpreted as the following:
@@ -298,6 +295,17 @@ type Group string
 // +kubebuilder:validation:Pattern=`^[a-zA-Z]([-a-zA-Z0-9]*[a-zA-Z0-9])?$`
 type Kind string
 
+// ObjectName refers to a Kubernetes object name.
+// Object names can have a variety of forms, including RFC1123 subdomains,
+// RFC 1123 labels, or RFC 1035 labels.
+// Therefore the validation for this type is set to the least restritive out of
+// those options, the RFC1123 subdomain.
+//
+// +kubebuilder:validation:MinLength=1
+// +kubebuilder:validation:MaxLength=253
+// +kubebuilder:validation:Pattern=`^(\*\.)?[a-z0-9]([-a-z0-9]*[a-z0-9])?(\.[a-z0-9]([-a-z0-9]*[a-z0-9])?)*$`
+type ObjectName string
+
 // Namespace refers to a Kubernetes namespace. It must be a RFC 1123 label.
 //
 // This validation is based off of the corresponding Kubernetes validation:

apis/v1alpha2/validation/httproute_test.go

@@ -25,8 +25,8 @@ import (
 )
 
 func TestValidateHTTPRoute(t *testing.T) {
-	testService := "test-service"
-	specialService := "special-service"
+	testService := gatewayv1a2.ObjectName("test-service")
+	specialService := gatewayv1a2.ObjectName("special-service")
 	tests := []struct {
 		name     string
 		hRoute   gatewayv1a2.HTTPRoute