Skip to content

Commit

Permalink
Merge pull request #1409 from skriss/pr-cherrypick-1382
Browse files Browse the repository at this point in the history 
(release-0.5 cherrypick of #1382) replace Attached condition with Accepted in HTTPRoute docs
  • Loading branch information
@k8s-ci-robot
k8s-ci-robot authored Sep 26, 2022
2 parents d4d3bcb + 5f557b5 commit cf625fd
Show file tree
Hide file tree
Showing 4 changed files with 48 additions and 48 deletions.
16 changes: 8 additions & 8 deletions apis/v1alpha2/httproute_types.go
View file
Original file line number Diff line number Diff line change
Expand Up @@ -249,7 +249,7 @@ type HTTPRouteRule struct {
// must ensure that unknown values will not cause a crash.
//
// Unknown values here must result in the implementation setting the
// Attached Condition for the Route to `status: False`, with a
// Accepted Condition for the Route to `status: False`, with a
// Reason of `UnsupportedValue`.
//
// +kubebuilder:validation:Enum=Exact;PathPrefix;RegularExpression
Expand Down Expand Up @@ -311,7 +311,7 @@ type HTTPPathMatch struct {
// must ensure that unknown values will not cause a crash.
//
// Unknown values here must result in the implementation setting the
// Attached Condition for the Route to `status: False`, with a
// Accepted Condition for the Route to `status: False`, with a
// Reason of `UnsupportedValue`.
//
// +kubebuilder:validation:Enum=Exact;RegularExpression
Expand Down Expand Up @@ -392,7 +392,7 @@ type HTTPHeaderMatch struct {
// must ensure that unknown values will not cause a crash.
//
// Unknown values here must result in the implementation setting the
// Attached Condition for the Route to `status: False`, with a
// Accepted Condition for the Route to `status: False`, with a
// Reason of `UnsupportedValue`.
//
// +kubebuilder:validation:Enum=Exact;RegularExpression
Expand Down Expand Up @@ -451,7 +451,7 @@ type HTTPQueryParamMatch struct {
// must ensure that unknown values will not cause a crash.
//
// Unknown values here must result in the implementation setting the
// Attached Condition for the Route to `status: False`, with a
// Accepted Condition for the Route to `status: False`, with a
// Reason of `UnsupportedValue`.
//
// +kubebuilder:validation:Enum=GET;HEAD;POST;PUT;DELETE;CONNECT;OPTIONS;TRACE;PATCH
Expand Down Expand Up @@ -558,7 +558,7 @@ type HTTPRouteFilter struct {
// must ensure that unknown values will not cause a crash.
//
// Unknown values here must result in the implementation setting the
// Attached Condition for the Route to `status: False`, with a
// Accepted Condition for the Route to `status: False`, with a
// Reason of `UnsupportedValue`.
//
// +unionDiscriminator
Expand Down Expand Up @@ -784,7 +784,7 @@ type HTTPPathModifier struct {
// must ensure that unknown values will not cause a crash.
//
// Unknown values here must result in the implementation setting the
// Attached Condition for the Route to `status: False`, with a
// Accepted Condition for the Route to `status: False`, with a
// Reason of `UnsupportedValue`.
//
// <gateway:experimental>
Expand Down Expand Up @@ -828,7 +828,7 @@ type HTTPRequestRedirectFilter struct {
// must ensure that unknown values will not cause a crash.
//
// Unknown values here must result in the implementation setting the
// Attached Condition for the Route to `status: False`, with a
// Accepted Condition for the Route to `status: False`, with a
// Reason of `UnsupportedValue`.
//
// +optional
Expand Down Expand Up @@ -871,7 +871,7 @@ type HTTPRequestRedirectFilter struct {
// must ensure that unknown values will not cause a crash.
//
// Unknown values here must result in the implementation setting the
// Attached Condition for the Route to `status: False`, with a
// Accepted Condition for the Route to `status: False`, with a
// Reason of `UnsupportedValue`.
//
// +optional
Expand Down
16 changes: 8 additions & 8 deletions apis/v1beta1/httproute_types.go
View file
Original file line number Diff line number Diff line change
Expand Up @@ -248,7 +248,7 @@ type HTTPRouteRule struct {
// must ensure that unknown values will not cause a crash.
//
// Unknown values here must result in the implementation setting the
// Attached Condition for the Route to `status: False`, with a
// Accepted Condition for the Route to `status: False`, with a
// Reason of `UnsupportedValue`.
//
// +kubebuilder:validation:Enum=Exact;PathPrefix;RegularExpression
Expand Down Expand Up @@ -310,7 +310,7 @@ type HTTPPathMatch struct {
// must ensure that unknown values will not cause a crash.
//
// Unknown values here must result in the implementation setting the
// Attached Condition for the Route to `status: False`, with a
// Accepted Condition for the Route to `status: False`, with a
// Reason of `UnsupportedValue`.
//
// +kubebuilder:validation:Enum=Exact;RegularExpression
Expand Down Expand Up @@ -391,7 +391,7 @@ type HTTPHeaderMatch struct {
// must ensure that unknown values will not cause a crash.
//
// Unknown values here must result in the implementation setting the
// Attached Condition for the Route to `status: False`, with a
// Accepted Condition for the Route to `status: False`, with a
// Reason of `UnsupportedValue`.
//
// +kubebuilder:validation:Enum=Exact;RegularExpression
Expand Down Expand Up @@ -450,7 +450,7 @@ type HTTPQueryParamMatch struct {
// must ensure that unknown values will not cause a crash.
//
// Unknown values here must result in the implementation setting the
// Attached Condition for the Route to `status: False`, with a
// Accepted Condition for the Route to `status: False`, with a
// Reason of `UnsupportedValue`.
//
// +kubebuilder:validation:Enum=GET;HEAD;POST;PUT;DELETE;CONNECT;OPTIONS;TRACE;PATCH
Expand Down Expand Up @@ -557,7 +557,7 @@ type HTTPRouteFilter struct {
// must ensure that unknown values will not cause a crash.
//
// Unknown values here must result in the implementation setting the
// Attached Condition for the Route to `status: False`, with a
// Accepted Condition for the Route to `status: False`, with a
// Reason of `UnsupportedValue`.
//
// +unionDiscriminator
Expand Down Expand Up @@ -783,7 +783,7 @@ type HTTPPathModifier struct {
// must ensure that unknown values will not cause a crash.
//
// Unknown values here must result in the implementation setting the
// Attached Condition for the Route to `status: False`, with a
// Accepted Condition for the Route to `status: False`, with a
// Reason of `UnsupportedValue`.
//
// <gateway:experimental>
Expand Down Expand Up @@ -827,7 +827,7 @@ type HTTPRequestRedirectFilter struct {
// must ensure that unknown values will not cause a crash.
//
// Unknown values here must result in the implementation setting the
// Attached Condition for the Route to `status: False`, with a
// Accepted Condition for the Route to `status: False`, with a
// Reason of `UnsupportedValue`.
//
// +optional
Expand Down Expand Up @@ -870,7 +870,7 @@ type HTTPRequestRedirectFilter struct {
// must ensure that unknown values will not cause a crash.
//
// Unknown values here must result in the implementation setting the
// Attached Condition for the Route to `status: False`, with a
// Accepted Condition for the Route to `status: False`, with a
// Reason of `UnsupportedValue`.
//
// +optional
Expand Down
40 changes: 20 additions & 20 deletions config/crd/experimental/gateway.networking.k8s.io_httproutes.yaml
View file

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Loading

0 comments on commit cf625fd

Please sign in to comment.