Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conformance Tests: HTTPRoute Filters #1103

Closed
13 of 14 tasks
robscott opened this issue Apr 8, 2022 · 10 comments
Closed
13 of 14 tasks

Conformance Tests: HTTPRoute Filters #1103

robscott opened this issue Apr 8, 2022 · 10 comments
Assignees
Labels
area/conformance help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. kind/feature Categorizes issue or PR as related to a new feature. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release.

Comments

@robscott
Copy link
Member

robscott commented Apr 8, 2022

This issue is intended to track conformance test development for HTTPRoute filters. Comment below if you're interested in working on covering any of these areas.

Core Capabilities:

Experimental Capabilities:

Extended Capabilities:

@robscott robscott added kind/feature Categorizes issue or PR as related to a new feature. area/conformance labels Apr 8, 2022
@skriss
Copy link
Contributor

skriss commented May 16, 2022

I've submitted #1163 for the header modifier set/add/remove cases.

@k8s-triage-robot
Copy link

The Kubernetes project currently lacks enough contributors to adequately respond to all issues and PRs.

This bot triages issues and PRs according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Mark this issue or PR as fresh with /remove-lifecycle stale
  • Mark this issue or PR as rotten with /lifecycle rotten
  • Close this issue or PR with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Sep 29, 2022
@mikemorris
Copy link
Contributor

/remove-lifecycle stale

@k8s-ci-robot k8s-ci-robot removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Oct 4, 2022
@shaneutt shaneutt added the help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. label Oct 4, 2022
@shaneutt shaneutt added this to the v0.7.0 milestone Oct 4, 2022
@shaneutt shaneutt modified the milestones: v0.7.0, v0.6.1 Nov 2, 2022
@sunjayBhatia
Copy link
Member

I think this issue should be augmented (or another created) to add testing for HTTPRoute Filters per-BackendRef as well, since the existing tests only test per-RouteRule

Part of that will include adding a test helper that can conditionally check a response has the correct content, given it was routed to a particular backend

@robscott
Copy link
Member Author

@LiorLieberman is working on conformance tests for HTTP Redirects.

@LiorLieberman
Copy link
Member

@robscott is request conformance for request mirroring still wanted?

also proposing changes to the description

...

Extended Capabilities:
Request Redirect: (@LiorLieberman)
[x] Scheme
[x] Port Number

Experimental Capabilities:
Request Redirect:
[x] Path
Request Rewrite: (@LiorLieberman )
[x] host
[x] Path

...

@robscott
Copy link
Member Author

robscott commented Feb 9, 2023

Thanks @LiorLieberman! Updated the issue to match. We are still looking for tests covering request mirroring.

@shaneutt shaneutt moved this to In Progress in Gateway API: The Road to GA Feb 21, 2023
@shaneutt shaneutt moved this from In Progress to Todo in Gateway API: The Road to GA Feb 21, 2023
@shaneutt shaneutt added the priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete. label Feb 21, 2023
@shaneutt shaneutt added priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. and removed priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete. labels Mar 8, 2023
@shaneutt shaneutt modified the milestones: v0.6.2, v0.7.0 Mar 14, 2023
@robscott robscott removed this from the v0.7.0 milestone Mar 24, 2023
@robscott robscott added this to the v0.8.0 milestone Mar 24, 2023
@shaneutt shaneutt removed this from the v0.8.0 milestone May 18, 2023
@shaneutt
Copy link
Member

At this point we only have one item left, talked with @robscott he's gonna close this and spin off the last one.

/assign @robscott

@LiorLieberman
Copy link
Member

What is the one item left? @shaneutt

@robscott
Copy link
Member Author

@LiorLieberman added #2037 to track the last part of this (combining HTTPRoute filters together in tests).

Going to close this one out in favor of that more specific one.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/conformance help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. kind/feature Categorizes issue or PR as related to a new feature. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release.
Projects
None yet
Development

No branches or pull requests

8 participants