Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conformance: HTTPRoute Filter Combinations #2037

Closed
4 tasks
robscott opened this issue May 18, 2023 · 5 comments · Fixed by #2101
Closed
4 tasks

Conformance: HTTPRoute Filter Combinations #2037

robscott opened this issue May 18, 2023 · 5 comments · Fixed by #2101
Assignees
Labels
area/conformance help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete.

Comments

@robscott
Copy link
Member

All HTTPRoute filters now have conformance tests as covered by #1103. Now we need some tests to cover combinations of them. At minimum we should aim to have all filters tested in combination with one other filter. Here's an example of what that could look like:

Core Combinations

  • Request Header Modifier and Request Redirect

Core and Extended Combinations

  • Request Header Modifier and URL Rewrite
  • Request Redirect and Request Mirror

Extended Combinations

  • Response Header Modifier and Request Mirror
@robscott
Copy link
Member Author

/help

@k8s-ci-robot
Copy link
Contributor

@robscott:
This request has been marked as needing help from a contributor.

Guidelines

Please ensure that the issue body includes answers to the following questions:

  • Why are we solving this issue?
  • To address this issue, are there any code changes? If there are code changes, what needs to be done in the code and what places can the assignee treat as reference points?
  • Does this issue have zero to low barrier of entry?
  • How can the assignee reach out to you for help?

For more details on the requirements of such an issue, please see here and ensure that they are met.

If this request no longer meets these requirements, the label can be removed
by commenting with the /remove-help command.

In response to this:

/help

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. label May 18, 2023
@robscott robscott added the priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete. label May 18, 2023
@Treenhan
Copy link
Contributor

Had an offline chat with @LiorLieberman - I am interested in taking this.

@LiorLieberman
Copy link
Member

/assign @Treenhan

@Treenhan
Copy link
Contributor

Treenhan commented Jun 8, 2023

@LiorLieberman I created a PR #2101 which combines one Core Capability (i.e. requestHeaderModifier) with other Extended Capabilities (i.e. requestMirror, responseHeaderModifier, and urlRewrite).

The list of Core/Extended capabilities was based on https://gateway-api.sigs.k8s.io/references/spec/#gateway.networking.k8s.io/v1beta1.HTTPRouteFilter

There is still work investigating whether it's possible to combine requestRedirect with other capabilities because this capability does not seem to work in any combination.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/conformance help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants