Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Conformance tests fail consistently in any scenario where the implementation takes longer to program the Gateway #2357

Closed
gauravkghildiyal opened this issue Aug 28, 2023 · 0 comments · Fixed by #2358
Closed

Conformance tests fail consistently in any scenario where the implementation takes longer to program the Gateway #2357

gauravkghildiyal opened this issue Aug 28, 2023 · 0 comments · Fixed by #2358
Assignees
@gauravkghildiyal
Labels
kind/bug Categorizes issue or PR as related to a bug. triage/accepted Indicates an issue or PR is ready to be actively worked on.
Milestone
v0.8.0

Comments

@gauravkghildiyal
Copy link
Member

gauravkghildiyal commented Aug 28, 2023 •
edited
Loading

What happened:

Conformance tests always fail in scenarios when the Gateway implementation takes relatively longer time to program the HTTPProxies.

What you expected to happen:

As long as the time to consistency is within the configured threshold, conformance tests should be able to succeed

gateway-api/conformance/utils/config/timeout.go

Line 105 in d54f5ee

MaxTimeToConsistency: 30 * time.Second,

How to reproduce it (as minimally and precisely as possible):

Run any conformance tests which involves making HTTP requests to the Gateway. Because of the nature of the problem (described in detail in #2358), reproducing it may depend on the Gateway implementation and environment from where the tests are run. Either way, the proposed fix in #2358 should be able to justify the issue.

Another common way in which this problem manifests is that the first test rain fails while the second test run succeeds.

Anything else we need to know?:

Proposed fix in #2358
@gauravkghildiyal gauravkghildiyal added the kind/bug Categorizes issue or PR as related to a bug. label Aug 28, 2023
@gauravkghildiyal gauravkghildiyal mentioned this issue Aug 28, 2023
Merged
@shaneutt shaneutt added the needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. label Aug 28, 2023
@shaneutt shaneutt added triage/accepted Indicates an issue or PR is ready to be actively worked on. and removed needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Aug 28, 2023
@shaneutt shaneutt moved this from Triage to In Progress in Gateway API: The Road to GA Aug 28, 2023
@shaneutt shaneutt added this to the v0.8.0 milestone Aug 28, 2023
@github-project-automation github-project-automation bot moved this from In Progress to Done in Gateway API: The Road to GA Aug 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@gauravkghildiyal gauravkghildiyal

Labels
kind/bug Categorizes issue or PR as related to a bug. triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
No open projects
Gateway API: The Road to GA
Status: Done
Milestone
v0.8.0
2 participants
@shaneutt @gauravkghildiyal