-
Notifications
You must be signed in to change notification settings - Fork 480
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix leaking TCP connections which leads to consistent conformance test failures #2358
Conversation
df3f764
to
60fbcef
Compare
c80c853
to
8b48c1d
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
DisableKeepAlives part lgtm
8b48c1d
to
849da79
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @gauravkghildiyal!
849da79
to
ddd0fd2
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/approve
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: arkodg, gauravkghildiyal, robscott The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Thanks @gauravkghildiyal! /lgtm |
What type of PR is this?
/kind bug
/kind test
What this PR does / why we need it:
The problem:
keep-alive
HTTP requests which means that after the HTTP request completes, we don't close the TCP connection.Solution:
Solution is pretty straightforward: we disable HTTP keep-alives.
Which issue(s) this PR fixes:
Fixes #2357
Does this PR introduce a user-facing change?: