CI tests are failing

[jpeach]

What happened:

CI test are failing with this error:

`Error from server (Invalid): error when creating "config/crd/v1alpha2/gateway.networking.k8s.io_gatewayclasses.yaml": CustomResourceDefinition.apiextensions.k8s.io "gatewayclasses.gateway.networking.k8s.io" is invalid: metadata.annotations[api-approved.kubernetes.io]: Required value: protected groups must have approval annotation "api-approved.kubernetes.io", see https://github.com/kubernetes/enhancements/pull/1111

What you expected to happen:

Applying CRDs should succeed.

How to reproduce it (as minimally and precisely as possible):

Run CI for any PR.

Anything else we need to know?:

kubernetes/enhancements#1111

[robscott]

This was a dumb hack by me to workaround this (https://github.com/kubernetes-sigs/gateway-api/blob/master/hack/update-codegen.sh#L63), and the precise version is probably causing the issue with #824 since it bumps the version of that tool.

[robscott]

@jpeach is there a specific PR where CI is failing due to this?

[robscott]

It looks like both recent PRs have failed CI for the same reason: #829 and #824. My working theory is that the recent updates to test-infra images these tests run on included an update to go v1.17. If this matches my own local development experience, go 1.17 adds an extra line at the start of these generated files. I'm guessing that running codegen with 1.17 would resolve this issue.

[youngnick]

I just installed 1.17, I'll give that a shot.

/assign

[robscott]

It looks like #830 fixed this, feel free to reopen if I missed anything.

/close

[k8s-ci-robot]

@robscott: Closing this issue.

In response to this:

It looks like #830 fixed this, feel free to reopen if I missed anything.

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.