-
Notifications
You must be signed in to change notification settings - Fork 490
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement GEP-957: Destination Port Matching. #1002
Conversation
Hi @cxhiano. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/ok-to-test |
Example added. PTAL Agreed that we could have a guide(probably in a separate PR). Should the guide be centered around Route <> Listener attachment or Route <> custom CRD(e.g. Mesh) attachment? I am not sure though. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @cxhiano! This mostly LGTM, do you mind creating a follow up issue to track adding docs for this feature?
52636b5
to
6c5f9c0
Compare
I created #1021 for tracking documentation improvement. |
/lgtm |
I think this is looking great, aside from the small note about the experimental status of Port in the stable docs. |
6c5f9c0
to
0290819
Compare
0290819
to
32c845d
Compare
@cxhiano looks like you need to run hack/update-codegen.sh, otherwise LGTM. /approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: cxhiano, howardjohn, robscott The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
32c845d
to
8c15033
Compare
Thanks! /lgtm |
What type of PR is this?
/kind feature
/kind api-change
What this PR does / why we need it:
Implement destination port matching proposed in gep-957
Does this PR introduce a user-facing change?: