-
Notifications
You must be signed in to change notification settings - Fork 490
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add GatewayClass Accepted print column #1168
add GatewayClass Accepted print column #1168
Conversation
👷 Deploy request for kubernetes-sigs-gateway-api pending review.Visit the deploys page to approve it
|
Hi @skriss. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
6557460
to
b80ac50
Compare
Adds the status of the "Accepted" condition to the GatewayClass print columns list. Signed-off-by: Steve Kriss <krisss@vmware.com>
b80ac50
to
1e53239
Compare
Works great for me, thanks @skriss! /ok-to-test |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: robscott, skriss The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What type of PR is this?
/kind feature
What this PR does / why we need it:
Adds the status of the "Accepted" condition
to the GatewayClass print columns list.
I find myself running
kubectl describe
to see this information all the time, thought it'd be useful to add to thekubectl get
output (and it's consistent with theGateway
output that shows the status of theReady
condition).Which issue(s) this PR fixes:
Does this PR introduce a user-facing change?: