Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add GatewayClass Accepted print column #1168

Merged

Conversation

skriss
Copy link
Contributor

@skriss skriss commented May 19, 2022

What type of PR is this?
/kind feature

What this PR does / why we need it:
Adds the status of the "Accepted" condition
to the GatewayClass print columns list.

I find myself running kubectl describe to see this information all the time, thought it'd be useful to add to the kubectl get output (and it's consistent with the Gateway output that shows the status of the Ready condition).

Which issue(s) this PR fixes:

Does this PR introduce a user-facing change?:

Adds the status of the GatewayClass "Accepted" condition to the GatewayClass print columns list/`kubectl get` output.

@k8s-ci-robot k8s-ci-robot added the kind/feature Categorizes issue or PR as related to a new feature. label May 19, 2022
@netlify
Copy link

netlify bot commented May 19, 2022

👷 Deploy request for kubernetes-sigs-gateway-api pending review.

Visit the deploys page to approve it

Name Link
🔨 Latest commit 1e53239

@k8s-ci-robot k8s-ci-robot added needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels May 19, 2022
@k8s-ci-robot
Copy link
Contributor

Hi @skriss. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot requested review from hbagdi and youngnick May 19, 2022 14:59
@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label May 19, 2022
@skriss skriss force-pushed the gatewayclass-accepted-printcolumn branch from 6557460 to b80ac50 Compare May 19, 2022 15:02
Adds the status of the "Accepted" condition
to the GatewayClass print columns list.

Signed-off-by: Steve Kriss <krisss@vmware.com>
@skriss skriss force-pushed the gatewayclass-accepted-printcolumn branch from b80ac50 to 1e53239 Compare May 19, 2022 15:02
@robscott
Copy link
Member

Works great for me, thanks @skriss!

/ok-to-test
/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels May 24, 2022
@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 24, 2022
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: robscott, skriss

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 24, 2022
@k8s-ci-robot k8s-ci-robot merged commit 50e6186 into kubernetes-sigs:master May 24, 2022
@skriss skriss deleted the gatewayclass-accepted-printcolumn branch May 24, 2022 18:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/feature Categorizes issue or PR as related to a new feature. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants