Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Generating CRDs and client code for v1beta1, removing v1alpha1 #1197

Merged
merged 1 commit into from
Jun 10, 2022

Conversation

robscott
Copy link
Member

@robscott robscott commented Jun 9, 2022

What type of PR is this?
/kind cleanup

What this PR does / why we need it:
This PR makes a number of changes, primarily related to generating code for v1beta1 and removing v1alpha1 types:

  • Removes v1alpha1 docs and types
  • Updates CRDs to include v1beta1 where applicable
  • Removes CRDs that haven't graduated to beta from standard channel
  • Updates v1beta1 types to strictly match v1alpha2 types (there were a couple more recent changes that were missed in recopy the v1beta1 types #1192)
  • Updates webhook to validate v1beta1 (in addition to v1alpha2)
  • Copies v1alpha2 examples to v1beta1 for verification

Does this PR introduce a user-facing change?:

NONE

@k8s-ci-robot k8s-ci-robot added kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Jun 9, 2022
@robscott robscott added this to the v0.5.0 milestone Jun 9, 2022
@k8s-ci-robot k8s-ci-robot added the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label Jun 9, 2022
@k8s-ci-robot k8s-ci-robot requested review from jpeach and thockin June 9, 2022 20:38
@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 9, 2022
@robscott
Copy link
Member Author

robscott commented Jun 9, 2022

/cc @shaneutt @youngnick

@robscott robscott changed the title Generating CRDs and client code for v1beta1 Generating CRDs and client code for v1beta1, removing v1alpha1 Jun 9, 2022
@robscott robscott force-pushed the v1beta1-generation branch from be238d5 to c7b9089 Compare June 9, 2022 20:44
@robscott robscott force-pushed the v1beta1-generation branch 2 times, most recently from 5d6ce71 to d13a69b Compare June 9, 2022 22:47
Copy link
Member

@shaneutt shaneutt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we're pretty close to good, just a couple things:

The README is still linking directly to v1alpha1:

[Go docs for the package](https://pkg.go.dev/sigs.k8s.io/gateway-api/apis/v1alpha1)

Looks like we should update that to v1beta1.

Also looks like HAProxy refers to specifically having v1alpha1 support in implementations.md:

HAProxy Ingress v0.13 partially supports the Gateway API's v1alpha1 specification. See the [controller's Gateway API documentation][h2] to get informed about conformance and roadmap.

Seems like we might want to give them a heads up, perhaps this is just out of date?

Other than that, I see a couple other references but those look like they can stay, historical stuff like blog posts and geps, e.t.c.

@robscott robscott force-pushed the v1beta1-generation branch from d13a69b to 9a3be9e Compare June 9, 2022 23:59
@robscott robscott force-pushed the v1beta1-generation branch from 9a3be9e to 750f978 Compare June 10, 2022 00:11
@robscott
Copy link
Member Author

Good catches @shaneutt, thanks!

The README is still linking directly to v1alpha1:

🤦 updated to v1alpha2 now (should eventually be v1b1).

HAProxy Ingress v0.13 partially supports the Gateway API's v1alpha1 specification. See the [controller's Gateway API documentation][h2] to get informed about conformance and roadmap.

@jcmoraisjr may have an update here

Copy link
Member

@shaneutt shaneutt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So there are a lot of changes in a single commit, but I looked through this and minus the things I pointed out above, I think we're good. 👍

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 10, 2022
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: robscott, shaneutt

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit 9186abe into kubernetes-sigs:master Jun 10, 2022
Copy link
Contributor

@youngnick youngnick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This LGTM, with one small comment.

I did realize when reviewing this though, that I think that, if you only install the standard channel CRDs, I don't think conformance will pass because ReferenceGrant is not present?

@@ -24,7 +24,6 @@ import (
// +kubebuilder:object:root=true
// +kubebuilder:resource:categories=gateway-api,shortName=gtw
// +kubebuilder:subresource:status
// +kubebuilder:storageversion
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just to confirm, we're leaving the storage version at v1alpha2 for now, and will migrate it later? This makes sense to me, but is probably worth calling out.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants