Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

conformance: listener references invalid secret #1334

Merged
merged 1 commit into from
Aug 19, 2022
Merged

conformance: listener references invalid secret #1334

merged 1 commit into from
Aug 19, 2022

Conversation

mlavacca
Copy link
Member

What type of PR is this?

/kind feature

What this PR does / why we need it:
A new conformance test case has been added to ensure that whenever a listener references an unexisting secret as CertificateRef, the Condition ResolvedRefs is set as failed with the reason InvalidCertificateRef.

Which issue(s) this PR fixes:

Fixes #1318

Does this PR introduce a user-facing change?:

NONE

@k8s-ci-robot k8s-ci-robot added kind/feature Categorizes issue or PR as related to a new feature. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Aug 16, 2022
@k8s-ci-robot
Copy link
Contributor

Hi @mlavacca. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Aug 16, 2022
@mlavacca mlavacca force-pushed the conformance-gateway-unexisting-secret branch from 0bb14e4 to 6e38436 Compare August 16, 2022 13:59
@mlavacca
conformance: listener references invalid secret
b2a847f 
A new conformance test case has been added to ensure that whenever a
listener references an unexisting secret as CertificateRef, the
Condition ResolvedRefs is set as failed with reason
InvalidCertificateRef.

Signed-off-by: Mattia Lavacca <lavacca.mattia@gmail.com>
@mlavacca mlavacca force-pushed the conformance-gateway-unexisting-secret branch from 6e38436 to b2a847f Compare August 16, 2022 13:59
@mlavacca mlavacca requested a review from shaneutt August 16, 2022 14:00
@shaneutt shaneutt self-assigned this Aug 16, 2022
@shaneutt
Copy link
Member

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Aug 16, 2022
@shaneutt shaneutt added this to the v0.6.0 milestone Aug 16, 2022
shaneutt
shaneutt approved these changes Aug 16, 2022
View reviewed changes
Copy link
Member

@shaneutt shaneutt left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mlavacca, shaneutt

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 16, 2022
@shaneutt shaneutt added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 19, 2022
@k8s-ci-robot k8s-ci-robot merged commit 3575f8f into kubernetes-sigs:main Aug 19, 2022
subi9 pushed a commit to subi9/gateway-api that referenced this pull request Aug 19, 2022
@k8s-ci-robot @subi9
yaml file matches with the example text.Merge pull request kubernetes…
38e8d36 
…-sigs#1334 from mlavacca/conformance-gateway-unexisting-secret

conformance: listener references invalid secret
@skriss skriss mentioned this pull request Aug 23, 2022
Merged
sunjayBhatia added a commit to projectcontour/contour that referenced this pull request Aug 25, 2022
@sunjayBhatia
internal/dag: Gateway Listeners with invalid references should have r…
6e6099a 
…eason RefNotPermitted (#4664)

See kubernetes-sigs/gateway-api#1305 and kubernetes-sigs/gateway-api#1334

Fixes conformance test failures on main

Signed-off-by: Sunjay Bhatia <sunjayb@vmware.com>
@robscott robscott mentioned this pull request Sep 19, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shaneutt shaneutt shaneutt approved these changes

@mikemorris mikemorris Awaiting requested review from mikemorris

Assignees

@shaneutt shaneutt

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/feature Categorizes issue or PR as related to a new feature. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
v0.6.0
Development

Successfully merging this pull request may close these issues.

conformance: test gateway referencing an unexisting tls secret
3 participants
@mlavacca @k8s-ci-robot @shaneutt