Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deploy webhook in pod admission restricted mode #2016

Merged
merged 1 commit into from
May 16, 2023
Merged

Deploy webhook in pod admission restricted mode #2016

merged 1 commit into from
May 16, 2023

Conversation

jcpunk
Copy link
Contributor

@jcpunk jcpunk commented May 12, 2023

What type of PR is this?

/kind feature
What this PR does / why we need it:
This PR provides defaults compatible with pod admission controller restricted policy for the webhook config.

Which issue(s) this PR fixes:

Fixes #

Does this PR introduce a user-facing change?:

Webhook config works with PodAdmission restricted

@k8s-ci-robot k8s-ci-robot added kind/feature Categorizes issue or PR as related to a new feature. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels May 12, 2023
@k8s-ci-robot
Copy link
Contributor

Welcome @jcpunk!

It looks like this is your first PR to kubernetes-sigs/gateway-api 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-sigs/gateway-api has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot k8s-ci-robot added needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels May 12, 2023
@k8s-ci-robot
Copy link
Contributor

Hi @jcpunk. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

shaneutt
shaneutt reviewed May 12, 2023
View reviewed changes
Copy link
Member

@shaneutt shaneutt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will need to hold momentarily until we release v0.7.0 (which is expected to happen in the next few days).

/hold

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label May 12, 2023
dprotaso
dprotaso reviewed May 12, 2023
View reviewed changes
config/webhook/admission_webhook.yaml Outdated
Comment on lines 85 to 86
runAsUser: 2000
runAsGroup: 2000
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

gateway-api/docker/Dockerfile.webhook

Line 30 in 6fee7b5

USER 65532

65532

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Interesting, I just copied the userid from certificate config. Should they both be updated to 65532?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This would be unique to our admission-server image.

@robscott
Copy link
Member

Thanks @jcpunk! Removing hold since v0.7.0 has been removed.

/hold cancel
/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels May 15, 2023
@jcpunk jcpunk force-pushed the psp-restricted branch 2 times, most recently from 9f05407 to 408210f Compare May 16, 2023 01:55
@jcpunk
Copy link
Contributor Author

jcpunk commented May 16, 2023

I'm not sure why the test are failing...

@gyohuangxin
Copy link
Member

@jcpunk It failed due to yaml files check, and the error messages can be found here: https://prow.k8s.io/view/gs/kubernetes-jenkins/pr-logs/pull/kubernetes-sigs_gateway-api/2016/pull-gateway-api-verify/1658290219671097344#1:build-log.txt%3A492

@jcpunk
Deploy webhook in pod admission restricted mode
b216b5b 
Signed-off-by: Pat Riehecky <riehecky@fnal.gov>
shaneutt
shaneutt approved these changes May 16, 2023
View reviewed changes
Copy link
Member

@shaneutt shaneutt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems good. Have we tested this locally?

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jcpunk, shaneutt

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@shaneutt shaneutt requested a review from robscott May 16, 2023 11:47
@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 16, 2023
@shaneutt shaneutt requested a review from youngnick May 16, 2023 11:47
@youngnick
Copy link
Contributor

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 16, 2023
@k8s-ci-robot k8s-ci-robot merged commit efaf748 into kubernetes-sigs:main May 16, 2023
@jcpunk jcpunk deleted the psp-restricted branch May 16, 2023 14:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dprotaso dprotaso dprotaso left review comments

@shaneutt shaneutt shaneutt approved these changes

@bowei bowei Awaiting requested review from bowei

@robscott robscott Awaiting requested review from robscott

@youngnick youngnick Awaiting requested review from youngnick

Assignees

@youngnick youngnick

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/feature Categorizes issue or PR as related to a new feature. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@jcpunk @k8s-ci-robot @robscott @gyohuangxin @youngnick @dprotaso @shaneutt