Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs(site-src): update the example for the matches #2185

Merged
merged 2 commits into from
Jul 17, 2023
Merged

docs(site-src): update the example for the matches #2185

merged 2 commits into from
Jul 17, 2023

Conversation

saltbo
Copy link
Member

@saltbo saltbo commented Jul 14, 2023

What type of PR is this?
/kind documentation

What this PR does / why we need it:
update the matches example to avoid misunderstanding

Which issue(s) this PR fixes:

Fixes #

Does this PR introduce a user-facing change?:

NONE

@saltbo
docs(site-src): update the example for the matches
c4106cc 
Signed-off-by: saltbo <saltbo@foxmail.com>
@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. kind/documentation Categorizes issue or PR as related to documentation. labels Jul 14, 2023
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jul 14, 2023
sunjayBhatia
sunjayBhatia suggested changes Jul 14, 2023
View reviewed changes
Copy link
Member

@sunjayBhatia sunjayBhatia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

left a comment on fixing the header match section

@saltbo
fix: error example for the headers
8567e7e 
Signed-off-by: saltbo <saltbo@foxmail.com>
@saltbo saltbo requested a review from sunjayBhatia July 16, 2023 08:14
@robscott
Copy link
Member

Thanks @saltbo!

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added lgtm "Looks good to me", indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Jul 17, 2023
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: robscott, saltbo, sunjayBhatia

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit ba78bf0 into kubernetes-sigs:main Jul 17, 2023
@saltbo saltbo deleted the docs/updateexample branch July 18, 2023 06:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sunjayBhatia sunjayBhatia sunjayBhatia approved these changes

@bowei bowei Awaiting requested review from bowei

@keithmattix keithmattix Awaiting requested review from keithmattix

Assignees

@robscott robscott

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/documentation Categorizes issue or PR as related to documentation. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@saltbo @robscott @k8s-ci-robot @sunjayBhatia