-
Notifications
You must be signed in to change notification settings - Fork 480
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use '$(POD_NAMESPACE)' instead of hardcoded namespace #2267
Conversation
Properly reads the namespace from the actual deployment
|
Welcome @dihmandrake! |
Hi @dihmandrake. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Hmm, neat, seems like a good idea to me. /ok-to-test |
Yes, this seems like a great improvement, thanks @dihmandrake. /approve |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me, thanks!
/approve
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: dihmandrake, mlavacca, youngnick The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Thanks @dihmandrake! /lgtm |
Properly reads the namespace from the actual deployment
What type of PR is this?
What this PR does / why we need it:
Do not hardcode the namespace for Pod arguments. The existing 'POD_NAMESPACE' variable suggests that the namespace should have actually been read at runtime. Similar to nginx-ingress in https://github.com/kubernetes/ingress-nginx/blob/d712dd9d92f1f46eab5f55d4643f3a45a7a97f90/charts/ingress-nginx/templates/admission-webhooks/job-patch/job-createSecret.yaml#L52C15-L52C43
Addtionally, this should enable easier deployments into non default namespaces with (i.e -) kustomize namespace setting
Which issue(s) this PR fixes:
Fixes #
Does this PR introduce a user-facing change?: