Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Expand and clarify Listeners definition #2288

Merged
merged 9 commits into from
Sep 25, 2023
Merged

Expand and clarify Listeners definition #2288

merged 9 commits into from
Sep 25, 2023

Commits on Aug 11, 2023

  1. Expand and clarify Listeners definition 

    Explicitly define Listener compatibility as definitively routable and
allowed on the same address by the implementation.

Narrow language about collapsing compatible Listeners to mean assigning
multiple Gateways the same addresses if their Listeners are compatible,

Expand Listeners examples to include mixed TCP and UDP and indicate that
they are not compatible if an implementation does not support that
combination.

Add language about Gateway-level conditions for incompatible Listeners.
    @rainest
    rainest committed Aug 11, 2023
    Configuration menu
    Copy the full SHA
    4f7706c View commit details
    Browse the repository at this point in the history

  2. chore: run make generate

    @rainest
    rainest committed Aug 11, 2023
    Configuration menu
    Copy the full SHA
    9e00746 View commit details
    Browse the repository at this point in the history

Commits on Aug 15, 2023

  1. Apply suggestions from code review 

    Co-authored-by: Rob Scott <rob.scott87@gmail.com>
    @rainest @robscott
    rainest and robscott authored Aug 15, 2023
    Configuration menu
    Copy the full SHA
    3bf6c14 View commit details
    Browse the repository at this point in the history

  2. pr: add hostname precedence example

    @rainest
    rainest committed Aug 15, 2023
    Configuration menu
    Copy the full SHA
    8a9acfb View commit details
    Browse the repository at this point in the history

  3. chore: make generate

    @rainest
    rainest committed Aug 15, 2023
    Configuration menu
    Copy the full SHA
    c390381 View commit details
    Browse the repository at this point in the history

Commits on Aug 21, 2023

  1. pr: rename collapse to merge

    @rainest
    rainest committed Aug 21, 2023
    Configuration menu
    Copy the full SHA
    3208a1f View commit details
    Browse the repository at this point in the history

Commits on Aug 29, 2023

  1. Use more generic rule for distinct Listeners

    @rainest
    rainest committed Aug 29, 2023
    Configuration menu
    Copy the full SHA
    dd27869 View commit details
    Browse the repository at this point in the history

  2. Add advice for cascading matches

    @rainest
    rainest committed Aug 29, 2023
    Configuration menu
    Copy the full SHA
    5af8b65 View commit details
    Browse the repository at this point in the history

Commits on Sep 19, 2023

  1. Revert "Add advice for cascading matches" 

    This reverts commit 5af8b65.
    @rainest
    rainest committed Sep 19, 2023
    Configuration menu
    Copy the full SHA
    c6912a5 View commit details
    Browse the repository at this point in the history