-
Notifications
You must be signed in to change notification settings - Fork 480
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conformance tests for static Gateway addresses #2412
Conformance tests for static Gateway addresses #2412
Conversation
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: shaneutt The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
0452c86
to
3cf8046
Compare
3cf8046
to
d147653
Compare
247f14a
to
f9ea74b
Compare
4c5425f
to
da94172
Compare
da94172
to
4b14d70
Compare
Signed-off-by: Shane Utt <shaneutt@linux.com>
… suite Signed-off-by: Shane Utt <shaneutt@linux.com>
9a4938c
to
bf2d448
Compare
0ba6401
to
8310caa
Compare
a3be3c8
to
8628ab3
Compare
Signed-off-by: Shane Utt <shaneutt@linux.com>
8628ab3
to
277e3f8
Compare
Signed-off-by: Shane Utt <shaneutt@linux.com>
This is now passing in Blixt, albeit I had to add several hacks to deal with the fact that our test suite is currently expecting if you do |
Thanks @shaneutt! /lgtm |
What type of PR is this?
/area conformance
/kind test
What this PR does / why we need it:
Going into GA we have an extended field for supplying static addresses for Gateways, but no conformance tests for that feature. This patch adds the test, while also tweaking some of the related condition reasons (see the explanation in the
CHANGELOG.md
).Which issue(s) this PR fixes:
Resolves #2035
Does this PR introduce a user-facing change?: