Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Istio status for Istio 1.22 and GW v1.1 #3025

Merged
merged 3 commits into from
May 9, 2024
Merged

Update Istio status for Istio 1.22 and GW v1.1 #3025

merged 3 commits into from
May 9, 2024

Conversation

howardjohn
Copy link
Contributor

What type of PR is this?

/kind documentation

What this PR does / why we need it:

Updates Istio status.

Which issue(s) this PR fixes:

Fixes #

Does this PR introduce a user-facing change?:

NONE

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. kind/documentation Categorizes issue or PR as related to documentation. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Apr 25, 2024
@k8s-ci-robot k8s-ci-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Apr 25, 2024
robscott
robscott reviewed Apr 25, 2024
View reviewed changes
Copy link
Member

@robscott robscott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @howardjohn!

conformance/reports/v1.1.0/istio-istio/1.22-report.yaml Outdated Show resolved Hide resolved
@mikemorris mikemorris mentioned this pull request Apr 29, 2024
Merged
This was referenced Apr 29, 2024
Merged
Open
Merged
@howardjohn howardjohn force-pushed the conformance/istio-1.1 branch 2 times, most recently from cb18b28 to c6c00df Compare May 1, 2024 17:45
robscott
robscott reviewed May 2, 2024
View reviewed changes
conformance/reports/v1.1.0/istio-istio/1.22-report.yaml Outdated
apiVersion: gateway.networking.k8s.io/v1alpha1
date: "2024-05-01T15:52:24Z"
gatewayAPIChannel: experimental
gatewayAPIVersion: v1.1.0-rc1
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This overall LGTM, but will hold off until this can target a release tag directly (RC2 should be released later today).

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Interestingly the report cannot report which SHA/tag we used, just the hardcoded string in the library. I wonder if Go exposes that...

Copy link
Member

@mlavacca mlavacca May 7, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The API version is taken from the Gateway API resources annotation (along with the API channel): https://github.com/kubernetes-sigs/gateway-api/blob/main/pkg/consts/consts.go#L19-L35

@howardjohn
Copy link
Contributor Author

@robscott this is on v1.1.0 now, so ready to go from my POV.

BTW, do these get cherrypicked or something or is the docs deploying from main?

@robscott
Copy link
Member

robscott commented May 9, 2024

Thanks @howardjohn! Docs still deploy from main but that will probably change some time before v1.2.

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 9, 2024
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: howardjohn, robscott

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 9, 2024
@k8s-ci-robot k8s-ci-robot merged commit a5b8cff into kubernetes-sigs:main May 9, 2024
8 checks passed
This was referenced May 16, 2024
Open
Open
@hh hh mentioned this pull request May 16, 2024
Open
3 tasks
BobyMCbobs pushed a commit to BobyMCbobs/kubernetes-sigs-gateway-api that referenced this pull request Jul 10, 2024
@howardjohn @BobyMCbobs
Update Istio status for Istio 1.22 and GW v1.1 (kubernetes-sigs#3025)
7713c25 
* Update Istio status for Istio 1.22 and GW v1.1

* Update with latest build

* v1.1.0 official
BobyMCbobs pushed a commit to BobyMCbobs/kubernetes-sigs-gateway-api that referenced this pull request Jul 22, 2024
@howardjohn @BobyMCbobs
Update Istio status for Istio 1.22 and GW v1.1 (kubernetes-sigs#3025)
4a4255e 
* Update Istio status for Istio 1.22 and GW v1.1

* Update with latest build

* v1.1.0 official
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@robscott robscott robscott left review comments

@michaelbeaumont michaelbeaumont Awaiting requested review from michaelbeaumont

@mlavacca mlavacca Awaiting requested review from mlavacca

@shaneutt shaneutt Awaiting requested review from shaneutt

Assignees

@robscott robscott

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/documentation Categorizes issue or PR as related to documentation. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@howardjohn @robscott @k8s-ci-robot @mlavacca