Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

expose GRPC conformance client as in interface #3095

Merged
merged 1 commit into from
May 20, 2024

Conversation

snehachhabria
Copy link
Contributor

What type of PR is this?
/kind test
/area conformance

What this PR does / why we need it:
The reason for this PR is explained in github issue: #3093

Which issue(s) this PR fixes:
Fixes # #3093

Does this PR introduce a user-facing change?:

Yes
Exposing grpc client interface as a option in the conformance suite

@k8s-ci-robot k8s-ci-robot added kind/test release-note Denotes a PR that will be considered when it comes time to generate release notes. area/conformance cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels May 17, 2024
@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels May 17, 2024
@k8s-ci-robot
Copy link
Contributor

Hi @snehachhabria. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Copy link
Contributor

@keithmattix keithmattix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: keithmattix, snehachhabria

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 20, 2024
@keithmattix
Copy link
Contributor

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels May 20, 2024
@keithmattix
Copy link
Contributor

Let's try this again
/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 20, 2024
@k8s-ci-robot k8s-ci-robot merged commit 7365f6a into kubernetes-sigs:main May 20, 2024
8 checks passed
@snehachhabria snehachhabria deleted the exposeGrpcClient branch May 20, 2024 20:27
@keithmattix
Copy link
Contributor

/cherry-pick release-1.1

@snehachhabria
Copy link
Contributor Author

If possible, could this be cherry-picked into release v1.1.0?

cc @robscott

@robscott
Copy link
Member

We actually just hadn't created the release-1.1 branch otherwise I think that cherry pick command should have worked.

/cherry-pick release-1.1

could this be cherry-picked into release v1.1.0

We'll need to do a patch release, usually we try to accumulate a few things over a couple of weeks so we don't end up with too many patch releases, let's aim for early June?

@k8s-infra-cherrypick-robot

@robscott: new pull request created: #3104

In response to this:

We actually just hadn't created the release-1.1 branch otherwise I think that cherry pick command should have worked.

/cherry-pick release-1.1

could this be cherry-picked into release v1.1.0

We'll need to do a patch release, usually we try to accumulate a few things over a couple of weeks so we don't end up with too many patch releases, let's aim for early June?

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@snehachhabria
Copy link
Contributor Author

We actually just hadn't created the release-1.1 branch otherwise I think that cherry pick command should have worked.

/cherry-pick release-1.1

could this be cherry-picked into release v1.1.0

We'll need to do a patch release, usually we try to accumulate a few things over a couple of weeks so we don't end up with too many patch releases, let's aim for early June?

sounds good to me, I am in no hurry we can use the commit from the release branch to unblock us.

thanks a lot @robscott and @keithmattix for the quick turn around

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/conformance cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/test lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants