-
Notifications
You must be signed in to change notification settings - Fork 480
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Correct PR link for GEP-995 implementation #3107
Conversation
Hi @craigbox. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
/release-note-none |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for fixing this, @craigbox!
/ok-to-test
Co-authored-by: Mattia Lavacca <lavacca.mattia@gmail.com>
/test pull-gateway-api-verify I'mma call this a flake but leave it to you all to figure out. |
Thanks @craigbox! /lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: craigbox, robscott The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
* Update index.md * Update geps/gep-2648/index.md Co-authored-by: Mattia Lavacca <lavacca.mattia@gmail.com> --------- Co-authored-by: Mattia Lavacca <lavacca.mattia@gmail.com>
* Update index.md * Update geps/gep-2648/index.md Co-authored-by: Mattia Lavacca <lavacca.mattia@gmail.com> --------- Co-authored-by: Mattia Lavacca <lavacca.mattia@gmail.com>
While reading https://gateway-api.sigs.k8s.io/geps/gep-2648/#migration-from-single-to-multiple-targets I saw this text:
Following through I see that 2593 is merged but needs a second PR to actually implement it. I've updated the text to say
so people don't have to walk the same path I did.