Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix the missing example in HTTP rewrite #3126

Merged
merged 3 commits into from
Jun 11, 2024
Merged

Fix the missing example in HTTP rewrite #3126

merged 3 commits into from
Jun 11, 2024

Conversation

spacewander
Copy link
Contributor

Also give them clearer names.
Signed-off-by: spacewander spacewanderlzx@gmail.com

What type of PR is this?

/kind documentation

What this PR does / why we need it:

There is expected to be one more example in the rewrite section.

Which issue(s) this PR fixes:

Fixes #

Does this PR introduce a user-facing change?:

NONE

@spacewander
Fix the missing example in HTTP rewrite
0d6bfe1 
Also give them clearer names.
Signed-off-by: spacewander <spacewanderlzx@gmail.com>
@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. kind/documentation Categorizes issue or PR as related to documentation. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Jun 3, 2024
@k8s-ci-robot
Copy link
Contributor

Hi @spacewander. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot added needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jun 3, 2024
@spacewander
add missing matches
b250e37 
Signed-off-by: spacewander <spacewanderlzx@gmail.com>
@k8s-ci-robot k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jun 3, 2024
robscott
robscott reviewed Jun 3, 2024
View reviewed changes
Copy link
Member

@robscott robscott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @spacewander!

/ok-to-test
/approve

examples/standard/http-redirect-rewrite/httproute-rewrite-prefix-path.yaml Show resolved Hide resolved
@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jun 3, 2024
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: robscott, spacewander

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 3, 2024
@spacewander
update name
4123e1a 
Signed-off-by: spacewander <spacewanderlzx@gmail.com>
@spacewander
Copy link
Contributor Author

@robscott
Would you review this PR again? Thanks!

@robscott
Copy link
Member

Thanks @spacewander! Sorry I'd lost track of this one!

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 11, 2024
@k8s-ci-robot k8s-ci-robot merged commit 0a01eeb into kubernetes-sigs:main Jun 11, 2024
8 checks passed
BobyMCbobs pushed a commit to BobyMCbobs/kubernetes-sigs-gateway-api that referenced this pull request Jul 10, 2024
@spacewander @BobyMCbobs
Fix the missing example in HTTP rewrite (kubernetes-sigs#3126)
f7d57b7 
* Fix the missing example in HTTP rewrite

Also give them clearer names.
Signed-off-by: spacewander <spacewanderlzx@gmail.com>

* add missing matches

Signed-off-by: spacewander <spacewanderlzx@gmail.com>

* update name

Signed-off-by: spacewander <spacewanderlzx@gmail.com>

---------

Signed-off-by: spacewander <spacewanderlzx@gmail.com>
BobyMCbobs pushed a commit to BobyMCbobs/kubernetes-sigs-gateway-api that referenced this pull request Jul 22, 2024
@spacewander @BobyMCbobs
Fix the missing example in HTTP rewrite (kubernetes-sigs#3126)
c697e02 
* Fix the missing example in HTTP rewrite

Also give them clearer names.
Signed-off-by: spacewander <spacewanderlzx@gmail.com>

* add missing matches

Signed-off-by: spacewander <spacewanderlzx@gmail.com>

* update name

Signed-off-by: spacewander <spacewanderlzx@gmail.com>

---------

Signed-off-by: spacewander <spacewanderlzx@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@robscott robscott robscott left review comments

@kflynn kflynn Awaiting requested review from kflynn

Assignees

@robscott robscott

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/documentation Categorizes issue or PR as related to documentation. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. release-note-none Denotes a PR that doesn't merit a release note. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@spacewander @k8s-ci-robot @robscott