Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: allow the header based session persistence not to have AbsoluteTimeout #3215

Merged

Conversation

sanposhiho
Copy link
Member

What type of PR is this?

/kind bug

What this PR does / why we need it:

This PR scope out the header based session persistence from the validation AbsoluteTimeout must be specified when cookie lifetimeType is Permanent.

See #3214.

Which issue(s) this PR fixes:

Fixes #3214

Does this PR introduce a user-facing change?:

NONE

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. kind/bug Categorizes issue or PR as related to a bug. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. labels Jul 24, 2024
@k8s-ci-robot k8s-ci-robot added kind/gep PRs related to Gateway Enhancement Proposal(GEP) cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jul 24, 2024
@sanposhiho
Copy link
Member Author

/retest

@robscott
Copy link
Member

Thanks @sanposhiho! Will defer to @gcs278 on this one, but this looks correct to me.

@robscott
Copy link
Member

/assign @gcs278

@gauravkghildiyal
Copy link
Member

Thanks!
/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 24, 2024
@gcs278
Copy link
Contributor

gcs278 commented Jul 24, 2024

Good catch, I missed this with the initial revision, and thanks for the fix!
/lgtm

@robscott
Copy link
Member

/approve
/cherry-pick release-1.1

@k8s-infra-cherrypick-robot

@robscott: once the present PR merges, I will cherry-pick it on top of release-1.1 in a new PR and assign it to you.

In response to this:

/approve
/cherry-pick release-1.1

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: robscott, sanposhiho

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 24, 2024
@sanposhiho
Copy link
Member Author

Thanks for the review, everyone. What's the rule around /hold label in the project? Is it OK to just /unhold?

@robscott
Copy link
Member

Thanks @sanposhiho!

We automatically add holds on any PR that modifies a GEP because we require at least two approvals on those. We've met that criteria here, so let's get this merged.

/hold cancel

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jul 26, 2024
@k8s-ci-robot k8s-ci-robot merged commit 89996b5 into kubernetes-sigs:main Jul 26, 2024
8 checks passed
@k8s-infra-cherrypick-robot

@robscott: new pull request created: #3221

In response to this:

/approve
/cherry-pick release-1.1

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. kind/gep PRs related to Gateway Enhancement Proposal(GEP) lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Header based session persistence cannot be configured without AbsoluteTimeout
6 participants