Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Valid BackendTLSPolicy with 1 targetRef/service using CACertificateRef and matching hostname #3265

Closed
wants to merge 6 commits into from
Closed

Valid BackendTLSPolicy with 1 targetRef/service using CACertificateRef and matching hostname #3265

wants to merge 6 commits into from

Conversation

whitneygriffith
Copy link
Contributor

What type of PR is this?

/area conformance

What this PR does / why we need it:

Adds conformance test for BackendTLSPolicy for the test case: Valid BackendTLSPolicy with 1 targetRef/service using CACertificateRef and matching hostname

Which issue(s) this PR fixes:

Part of #3138

Does this PR introduce a user-facing change?:

NONE

candita and others added 4 commits July 23, 2024 16:32
@candita
WIP Issue 3138 - Conformance Tests for BackendTLSPolicy - normative
76c8e10
@whitneygriffith
rm clientCert and clientPrivKey
029ba5a 
Signed-off-by: Whitney Griffith <whitney.griffith16@gmail.com>
@whitneygriffith
setup cluster for hostname verification
d5395b2 
Signed-off-by: Whitney Griffith <whitney.griffith16@gmail.com>
@whitneygriffith
setup cluster for valid backendTLSPolicy
7ab55a8 
Signed-off-by: Whitney Griffith <whitney.griffith16@gmail.com>
@k8s-ci-robot k8s-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. release-note-none Denotes a PR that doesn't merit a release note. area/conformance cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Aug 12, 2024
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: whitneygriffith
Once this PR has been reviewed and has the lgtm label, please assign danwinship for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Aug 12, 2024
@k8s-ci-robot
Copy link
Contributor

Hi @whitneygriffith. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Aug 12, 2024
@keithmattix
Copy link
Contributor

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Aug 12, 2024
@k8s-ci-robot
Copy link
Contributor

@whitneygriffith: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-gateway-api-verify 7ab55a8 link true /test pull-gateway-api-verify

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@whitneygriffith
update test
5529562 
Signed-off-by: Whitney Griffith <whitney.griffith16@gmail.com>
@whitneygriffith
Copy link
Contributor Author

/test pull-gateway-api-verify

@whitneygriffith
update test
b8aeb2e 
Signed-off-by: Whitney Griffith <whitney.griffith16@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Xunzhuo Xunzhuo Awaiting requested review from Xunzhuo

@youngnick youngnick Awaiting requested review from youngnick

Assignees
No one assigned
Labels
area/conformance cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@whitneygriffith @k8s-ci-robot @keithmattix @candita