Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix a number of GEP stage errors #3359

Merged
merged 6 commits into from
Sep 26, 2024
Merged

Fix a number of GEP stage errors #3359

merged 6 commits into from
Sep 26, 2024

Conversation

youngnick
Copy link
Contributor

/kind cleanup
/kind documentation

What this PR does / why we need it:

This PR fixes the state of a number of GEPs in preparation for the 1.2 release.

It also fixes GEP-1426, which really should be called GEP-1294, since that is the issue number. #1426 was the PR that implemented it.

Individual changes per commit, since we squash by default anyway.

I'll check using Netlify that the redirect I added works correctly and update accordingly.

@youngnick
Move GEP-3171 to Experimental
222aa09 
Signed-off-by: Nick Young <nick@isovalent.com>
@youngnick
Move GEP-1762 to Standard
1dcdefa 
Signed-off-by: Nick Young <nick@isovalent.com>
@youngnick
Move GEP-1911 to Standard
76e3aaf 
Signed-off-by: Nick Young <nick@isovalent.com>
@youngnick
Move GEP-3155 to Experimental
1dacd89 
Signed-off-by: Nick Young <nick@isovalent.com>
@youngnick
Move GEP-995 to Experimental
083219a 
Signed-off-by: Nick Young <nick@isovalent.com>
@k8s-ci-robot k8s-ci-robot added kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. kind/documentation Categorizes issue or PR as related to documentation. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/gep PRs related to Gateway Enhancement Proposal(GEP) labels Sep 25, 2024
@k8s-ci-robot k8s-ci-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Sep 25, 2024
@youngnick youngnick added the release-note-none Denotes a PR that doesn't merit a release note. label Sep 25, 2024
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. label Sep 25, 2024
@youngnick
Fix incorrect GEP-1426 number - should be 1294
6292946 
Signed-off-by: Nick Young <nick@isovalent.com>
youngnick
youngnick commented Sep 25, 2024
View reviewed changes
netlify.toml
Comment on lines +30 to +32
from = "/geps/gep-1426"
to = "/geps/gep-1294"
status = 301
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Deploy preview shows this working correctly.

See https://deploy-preview-3359--kubernetes-sigs-gateway-api.netlify.app/geps/gep-1426/

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

wonder why we need that? for previous versions of the website?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In case there are permalinks anywhere that point to the Service Mesh GEP (which used to incorrectly be at that location). This will redirect people to the now corrected page.

LiorLieberman
LiorLieberman approved these changes Sep 25, 2024
View reviewed changes
Copy link
Member

@LiorLieberman LiorLieberman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/hold for my comment and in case you are looking for another review

netlify.toml
Comment on lines +30 to +32
from = "/geps/gep-1426"
to = "/geps/gep-1294"
status = 301
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

wonder why we need that? for previous versions of the website?

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 25, 2024
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: LiorLieberman, youngnick

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@robscott
Copy link
Member

Thanks @youngnick!

/lgtm

@robscott
Copy link
Member

/hold cancel

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Sep 26, 2024
@k8s-ci-robot k8s-ci-robot merged commit 2263ec4 into kubernetes-sigs:main Sep 26, 2024
13 checks passed
@youngnick youngnick mentioned this pull request Sep 30, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LiorLieberman LiorLieberman LiorLieberman approved these changes

@mikemorris mikemorris Awaiting requested review from mikemorris

Assignees

@robscott robscott

@LiorLieberman LiorLieberman

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. kind/documentation Categorizes issue or PR as related to documentation. kind/gep PRs related to Gateway Enhancement Proposal(GEP) lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@youngnick @k8s-ci-robot @robscott @LiorLieberman