Disable v1alpha2 versions for GRPCRoute and ReferenceGrant #3361
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
kind/cleanup
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: youngnick The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
approved
|
Thanks @youngnick! I should also note that both versions that are being removed here were previously marked as deprecated with a warning that they "will be removed in a future release of the API". /lgtm (Will remove hold before RC2 release tomorrow) |
k8s-ci-robot
added
the
do-not-merge/hold
k8s-ci-robot
added
the
lgtm
youngnick
force-pushed
the
disable-v1alpha2-resources
branch
from
e35c3a9
to
2255b72
Compare
k8s-ci-robot
added
size/M
youngnick
force-pushed
the
disable-v1alpha2-resources
branch
from
2255b72
to
f1d4fa4
Compare
k8s-ci-robot
added
size/L
Signed-off-by: Nick Young <nick@isovalent.com>
youngnick
force-pushed
the
disable-v1alpha2-resources
branch
from
f1d4fa4
to
7afdf23
Compare
|
/lgtm |
k8s-ci-robot
added
the
lgtm
|
/retest |
|
/hold cancel |
k8s-ci-robot
removed
the
do-not-merge/hold
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
/kind cleanup
/kind documentation
What this PR does / why we need it:
This PR disables serving of
v1alpha2versions of both ReferenceGrant and GRPCRoute.This should not be a breaking change, as both GRPCRoute and ReferenceGrant have had their
Storage Version set to the
v1orv1beta1versions respectively for some time. This will just meanthat users can no longer use the
v1alpha2in theirapiVersionfield when fetching or applying thoseobjects.