Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding conflict resolution guidance for equivalent rules within a route #620

Merged
merged 1 commit into from
Apr 22, 2021

Conversation

robscott
Copy link
Member

What type of PR is this?
/kind cleanup
/kind documentation

What this PR does / why we need it:
This adds conflict resolution guidance for equivalent rules within a route.

Which issue(s) this PR fixes:
Fixes #613

Does this PR introduce a user-facing change?:

Adds conflict resolution guidance for equivalent rules within a route

/cc @stevesloka @youngnick @hbagdi

@k8s-ci-robot k8s-ci-robot requested a review from youngnick April 21, 2021 17:36
@k8s-ci-robot k8s-ci-robot added the kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. label Apr 21, 2021
@k8s-ci-robot
Copy link
Contributor

@robscott: GitHub didn't allow me to request PR reviews from the following users: stevesloka.

Note that only kubernetes-sigs members and repo collaborators can review this PR, and authors cannot review their own PRs.

In response to this:

What type of PR is this?
/kind cleanup
/kind documentation

What this PR does / why we need it:
This adds conflict resolution guidance for equivalent rules within a route.

Which issue(s) this PR fixes:
Fixes #613

Does this PR introduce a user-facing change?:

Adds conflict resolution guidance for equivalent rules within a route

/cc @stevesloka @youngnick @hbagdi

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot requested a review from hbagdi April 21, 2021 17:36
@k8s-ci-robot k8s-ci-robot added kind/documentation Categorizes issue or PR as related to documentation. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Apr 21, 2021
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: robscott

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Apr 21, 2021
@robscott robscott added this to the v0.3.0 milestone Apr 21, 2021
@hbagdi
Copy link
Contributor

hbagdi commented Apr 21, 2021

/lgtm

@youngnick had some thoughts here so let's wait for his review too.
/hold

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Apr 21, 2021
@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 21, 2021
@youngnick
Copy link
Contributor

/lgtm

Yeah, I think the first-matching is slightly better than last-matching. Thanks for making this update @robscott!

@robscott
Copy link
Member Author

/hold cancel

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Apr 22, 2021
@k8s-ci-robot k8s-ci-robot merged commit ff34b80 into kubernetes-sigs:master Apr 22, 2021
@robscott robscott deleted the route-rule-conflicts branch January 8, 2022 01:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. kind/documentation Categorizes issue or PR as related to documentation. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
No open projects
Archived in project
Development

Successfully merging this pull request may close these issues.

Clarify route conflicts in the same resource
4 participants