-
Notifications
You must be signed in to change notification settings - Fork 490
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding conflict resolution guidance for equivalent rules within a route #620
Adding conflict resolution guidance for equivalent rules within a route #620
Conversation
@robscott: GitHub didn't allow me to request PR reviews from the following users: stevesloka. Note that only kubernetes-sigs members and repo collaborators can review this PR, and authors cannot review their own PRs. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: robscott The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/lgtm @youngnick had some thoughts here so let's wait for his review too. |
/lgtm Yeah, I think the first-matching is slightly better than last-matching. Thanks for making this update @robscott! |
/hold cancel |
What type of PR is this?
/kind cleanup
/kind documentation
What this PR does / why we need it:
This adds conflict resolution guidance for equivalent rules within a route.
Which issue(s) this PR fixes:
Fixes #613
Does this PR introduce a user-facing change?:
/cc @stevesloka @youngnick @hbagdi